Reduce trim min size even lower for tests to reduce flakiness #15315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Let's also set this to 512 for these tests. I believe I've seen spurious failures for several of these as well and it'd be nice to rule this out as a possible cause.
tests/zfs-tests/tests/functional/trim/trim_config.ksh
tests/zfs-tests/tests/functional/trim/autotrim_config.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_trim/zpool_trim_verify_trimmed.ksh
tests/zfs-tests/tests/functional/cli_root/zpool_trim/zpool_trim_partial.ksh
Signed-off-by: Paul Dagnelie <[email protected]>
gmelikov
approved these changes
Sep 26, 2023
behlendorf
approved these changes
Sep 26, 2023
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Sep 28, 2023
Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Paul Dagnelie <[email protected]> Closes openzfs#15315
behlendorf
pushed a commit
that referenced
this pull request
Sep 28, 2023
Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Paul Dagnelie <[email protected]> Closes #15315
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Paul Dagnelie <[email protected]> Closes openzfs#15315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We have intermittent failures in the trim test suite because the raidz pools don't end up issuing enough TRIM IOs to satisfy the tests. I analyzed their behavior with some debug messages and found that there were huge numbers of trims being considered, but rejected for being below 4096 bytes.
Description
We drop the limit lower, to 512 bytes, so that all the trim IOs will be issued.
How Has This Been Tested?
ZTS runs
Types of changes
Checklist:
Signed-off-by.