Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set timeout before creating pool in test #15309

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Set timeout before creating pool in test #15309

merged 1 commit into from
Sep 25, 2023

Conversation

pcd1193182
Copy link
Contributor

@pcd1193182 pcd1193182 commented Sep 22, 2023 •
edited
Loading

Motivation and Context

Occasionally block_cloning_copyfilerange_fallback_same_txg fails because the clone happens in a later txg than the file creation. This can happen because the 5000 second timeout is set but we then immediately go on to the creation; there may still be a quick TXG in the pipeline that causes the clone to happen in a separate TXG.

Description

We set the timeout before creating the pool; this is what it is done in the mmp tests, which make extensive use of the txg timeout tunable. That way, all txgs are guaranteed to be long ones.

How Has This Been Tested?

ZTS runs, none of which have failed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

robn
robn approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@robn robn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's much better, nice one.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 22, 2023
@behlendorf behlendorf merged commit 8a9ba76 into openzfs:master Sep 25, 2023
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 26, 2023
@pcd1193182 @behlendorf
Set timeout before creating pool in test
0dc8183 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Signed-off-by: Paul Dagnelie <[email protected]>
Closes openzfs#15309
behlendorf pushed a commit that referenced this pull request Sep 28, 2023
@pcd1193182 @behlendorf
Set timeout before creating pool in test
8526b12 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Signed-off-by: Paul Dagnelie <[email protected]>
Closes #15309
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@pcd1193182 @lundman
Set timeout before creating pool in test
3f97f81 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Signed-off-by: Paul Dagnelie <[email protected]>
Closes openzfs#15309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@robn robn robn approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcd1193182 @robn @behlendorf