Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allocate from new metaslabs #15308

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

pcd1193182
Copy link
Contributor

@pcd1193182 pcd1193182 commented Sep 22, 2023

Motivation and Context

See #15307

Description

We check in metaslab_should_alloc if the metaslab is new or not.

How Has This Been Tested?

zloop runs; the issue was rare before, and has not recurred, but that is not necessarily a guarantee of a fix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. It would also be possible for the raidz expansion code to hit this when it's merged.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 22, 2023
@behlendorf
Copy link
Contributor

@pcd1193182 any updates on this after the weekend, or does it appear to be sufficient in it's current form.

@pcd1193182
Copy link
Contributor Author

I saw a couple related issues in my long weekend runs, so I'm investigating further now.

@behlendorf behlendorf merged commit 5551dcd into openzfs:master Sep 28, 2023
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 28, 2023
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Dagnelie <[email protected]>
Closes openzfs#15307
Closes openzfs#15308
behlendorf pushed a commit that referenced this pull request Sep 28, 2023
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Dagnelie <[email protected]>
Closes #15307
Closes #15308
@pcd1193182 pcd1193182 deleted the should_alloc branch September 29, 2023 18:42
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Paul Dagnelie <[email protected]>
Closes openzfs#15307
Closes openzfs#15308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants