Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: install missing PAM tests #15291

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

robn
Copy link
Member

@robn robn commented Sep 18, 2023

Description

pam_change_unmounted and pam_recursive both exist and are referenced by the test run config, but weren't being installed and so were excluded. This gets them installed so they will run as expected.

How Has This Been Tested?

Ran the test suite for the pam tag; tests were included and all passed. The runners will get anything else, though I can't imagine what there might be!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

'pam_change_unmounted' and 'pam_recursive' both exist and are referenced
by the test run config, but weren't being installed and so are excluded.
This gets them installed so they will run as expected.

Signed-off-by: Rob Norris <[email protected]>
@robn robn force-pushed the pam-missing-tests branch from ed3ad6c to 9d6300e Compare September 18, 2023 22:03
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 18, 2023
@behlendorf behlendorf merged commit 6cb933c into openzfs:master Sep 19, 2023
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 20, 2023
'pam_change_unmounted' and 'pam_recursive' both exist and are referenced
by the test run config, but weren't being installed and so are excluded.
This gets them installed so they will run as expected.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Kay Pedersen <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#15291
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 21, 2023
'pam_change_unmounted' and 'pam_recursive' both exist and are referenced
by the test run config, but weren't being installed and so are excluded.
This gets them installed so they will run as expected.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Kay Pedersen <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#15291
behlendorf pushed a commit that referenced this pull request Sep 22, 2023
'pam_change_unmounted' and 'pam_recursive' both exist and are referenced
by the test run config, but weren't being installed and so are excluded.
This gets them installed so they will run as expected.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Kay Pedersen <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes #15291
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
'pam_change_unmounted' and 'pam_recursive' both exist and are referenced
by the test run config, but weren't being installed and so are excluded.
This gets them installed so they will run as expected.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Kay Pedersen <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Closes openzfs#15291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants