Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-zstd-symbols: also ignore __pfx_ symbols #15284

Merged
merged 1 commit into from
Sep 18, 2023
Merged

check-zstd-symbols: also ignore __pfx_ symbols #15284

merged 1 commit into from
Sep 18, 2023

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented Sep 16, 2023 •
edited
Loading

Motivation and Context

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b341b20d648bb7e9a3307c33163e7399f0913e66, #15282

How Has This Been Tested?

Pasted 0000000000004dd0 g F .text 0000000000000010 __pfx_zfs_ZSTD_estimateDStreamSize into awk '/file format/ {print} $2 == "g" && (!/ zfs_/ && !/ __pfx_zfs/) {++ret; print} END {exit ret}' and it swallowed it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. — likewise
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli nabijaczleweli mentioned this pull request Sep 16, 2023
Closed
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 18, 2023
@behlendorf behlendorf merged commit 9192ab7 into openzfs:master Sep 18, 2023
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Sep 19, 2023
@nabijaczleweli @behlendorf
check-zstd-symbols: also ignore __pfx_ symbols
c1cdb62 
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b341b20d648bb7e9a3307c33163e7399f0913e66

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#15282 
Closes openzfs#15284
behlendorf pushed a commit that referenced this pull request Sep 19, 2023
@nabijaczleweli @behlendorf
check-zstd-symbols: also ignore __pfx_ symbols
0ce7a06 
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b341b20d648bb7e9a3307c33163e7399f0913e66

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #15282 
Closes #15284
tonyhutter pushed a commit that referenced this pull request Sep 27, 2023
@nabijaczleweli @tonyhutter
check-zstd-symbols: also ignore __pfx_ symbols
a3169da 
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b341b20d648bb7e9a3307c33163e7399f0913e66

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #15282
Closes #15284
@EchterAgo EchterAgo mentioned this pull request Oct 11, 2023
Merged
EchterAgo pushed a commit to EchterAgo/zfs that referenced this pull request Oct 11, 2023
@nabijaczleweli @EchterAgo
check-zstd-symbols: also ignore __pfx_ symbols
dacb69c 
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b341b20d648bb7e9a3307c33163e7399f0913e66

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#15282 
Closes openzfs#15284
EchterAgo pushed a commit to EchterAgo/zfs that referenced this pull request Oct 11, 2023
@nabijaczleweli @EchterAgo
check-zstd-symbols: also ignore __pfx_ symbols
8e1cdf9 
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b341b20d648bb7e9a3307c33163e7399f0913e66

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#15282 
Closes openzfs#15284
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Oct 11, 2023
@EchterAgo @nabijaczleweli
check-zstd-symbols: also ignore __pfx_ symbols (#285)
c864cfb 
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b341b20d648bb7e9a3307c33163e7399f0913e66

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#15282 
Closes openzfs#15284

Co-authored-by: наб <[email protected]>
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@nabijaczleweli @lundman
check-zstd-symbols: also ignore __pfx_ symbols
75f047b 
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b341b20d648bb7e9a3307c33163e7399f0913e66

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#15282 
Closes openzfs#15284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrens ahrens ahrens approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabijaczleweli @behlendorf @ahrens