Revert "ZFS_IOC_COUNT_FILLED does unnecessary txg_wait_synced()" #14761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4b3133e. Users identified this commit as a possible source of data corruption: openzfs#14753 Signed-off-by: Tony Hutter <[email protected]>
behlendorf
approved these changes
Apr 18, 2023
tonyhutter
added a commit
to tonyhutter/zfs
that referenced
this pull request
Apr 18, 2023
This reverts commit 4b3133e. Users identified this commit as a possible source of data corruption: openzfs#14753 Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tony Hutter <[email protected]> Issue openzfs#14753 Closes openzfs#14761
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Apr 20, 2023
This reverts commit 4b3133e. Users identified this commit as a possible source of data corruption: openzfs#14753 Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tony Hutter <[email protected]> Issue openzfs#14753 Closes openzfs#14761
|
Hello, just for information, how severe is this bug? And when can we consider a zfs release stable? Even with data corruption stated here, is it something that can be catched by zfs checksum on files? |
ZFS mechanisms (checksum, scrub) do not catch this corruption whatsoever. |
|
Thank you, is it something that could happen under some sort of stress of the filesystem or simply having this wrong zfs version and light use?On 25 Apr 2023, at 05:40, Charlie Li ***@***.***> wrote:
Even with data corruption stated here, is it something that can be catched by zfs checksum on files?
ZFS mechanisms (checksum, scrub) do not catch this corruption whatsoever.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Apr 30, 2023
This reverts commit 4b3133e. Users identified this commit as a possible source of data corruption: openzfs#14753 Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tony Hutter <[email protected]> Issue openzfs#14753 Closes openzfs#14761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This reverts commit 4b3133e.
Description
Users identified this commit as a possible source of data corruption: #14753
How Has This Been Tested?
Test build only
Types of changes
Checklist:
Signed-off-by.