zdb: zero-pad checksum output follow up #14497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply zero padding for checksums consistently. The SNPRINTF_BLKPTR macro was not updated in commit ac76481 which results in the cli_root/zdb/zdb_checksum.ksh test case reliably failing. Signed-off-by: Brian Behlendorf <[email protected]>
bwatkinson
approved these changes
Feb 14, 2023
ikozhukhov
approved these changes
Feb 15, 2023
akashb-22
approved these changes
Feb 15, 2023
behlendorf
added
Status: Accepted
|
Ugh, sorry, and thanks. I actually had this in the original change but managed to miss it when assembling the commit. |
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 3, 2023
Apply zero padding for checksums consistently. The SNPRINTF_BLKPTR macro was not updated in commit ac76481 which results in the `cli_root/zdb/zdb_checksum.ksh` test case reliably failing. Reviewed-by: Igor Kozhukhov <[email protected]> Reviewed-by: Akash B <[email protected]> Reviewed-by: Brian Atkinson <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#14497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Resolve
zdb_checksumZTS failures introduced by ac76481. Alternately, we could revert the original patch if we find this formatting change breaks other tests or support scripts.Description
Apply zero padding for checksums consistently. The SNPRINTF_BLKPTR macro was not updated in commit ac76481 which results in the cli_root/zdb/zdb_checksum.ksh test case reliably failing.
How Has This Been Tested?
Verified the failing test case now passed. Waiting on the CI for a full test run.
Types of changes
Checklist:
Signed-off-by.