Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zed: Avoid core dump if wholedisk property does not exist #14062

Merged
merged 1 commit into from
Oct 21, 2022
Merged

zed: Avoid core dump if wholedisk property does not exist #14062

merged 1 commit into from
Oct 21, 2022

Conversation

ixhamza
Copy link
Member

@ixhamza ixhamza commented Oct 20, 2022

Motivation and Context

zed aborts and dumps core in vdev_whole_disk_from_config() if the wholedisk property does not exist. make_leaf_vdev() adds the property but there may be already pools that don't have the wholedisk in the label.

How Has This Been Tested?

By creating pools through py-libzfs that did not populate the wholedisk parameter previously.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ixhamza
Copy link
Member Author

ixhamza commented Oct 20, 2022

@amotin, @freqlabs.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 20, 2022
amotin
amotin approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 1005 lack of the property is also ignored, and the code style could be unified.

@ixhamza
zed: Avoid core dump if wholedisk property does not exist
5621f83 
zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Signed-off-by: Ameer Hamza <[email protected]>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 20, 2022
@behlendorf behlendorf merged commit 0b2428d into openzfs:master Oct 21, 2022
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 22, 2022
@ixhamza @andrewc12
zed: Avoid core dump if wholedisk property does not exist
42598a5 
zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14062
ixhamza added a commit to truenas/zfs that referenced this pull request Oct 24, 2022
@ixhamza
zed: Avoid core dump if wholedisk property does not exist
a977def 
zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14062
@ixhamza ixhamza mentioned this pull request Oct 24, 2022
Merged
13 tasks
ixhamza added a commit to truenas/zfs that referenced this pull request Nov 7, 2022
@ixhamza
zed: Avoid core dump if wholedisk property does not exist
fc62f9b 
zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14062
@ixhamza ixhamza mentioned this pull request Nov 7, 2022
Merged
13 tasks
behlendorf pushed a commit that referenced this pull request Nov 8, 2022
@ixhamza @behlendorf
zed: Avoid core dump if wholedisk property does not exist
8c0684d 
zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes #14062
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@ixhamza @andrewc12
zed: Avoid core dump if wholedisk property does not exist
3882a9b 
zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14062
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@ixhamza @andrewc12
zed: Avoid core dump if wholedisk property does not exist
47e1ce4 
zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14062
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@ixhamza @andrewc12
zed: Avoid core dump if wholedisk property does not exist
8342e69 
zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14062
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@ixhamza @andrewc12
zed: Avoid core dump if wholedisk property does not exist
4bbff8c 
zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14062
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Nov 9, 2022
@ixhamza @andrewc12
zed: Avoid core dump if wholedisk property does not exist
f7b4cf9 
zed aborts and dumps core in vdev_whole_disk_from_config() if
wholedisk property does not exist. make_leaf_vdev() adds the
property but there may be already pools that don't have the
wholedisk in the label.

Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Richard Yao <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#14062
@ixhamza ixhamza deleted the NAS-118635 branch August 2, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@ryao ryao ryao approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ixhamza @ryao @amotin @behlendorf