Add zhack scrub sub command for offline scrubs in userland #14037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmilk
force-pushed
the
zhack-scrub
branch
2 times, most recently
from
92fbc7c to
720fbcd
Compare
behlendorf
added
the
Status: Design Review Needed
mcmilk
force-pushed
the
zhack-scrub
branch
2 times, most recently
from
e2b7a96 to
b46aa69
Compare
13 tasks
+ Allow physmem to be specified before kernel_init() This PR adds a "zhack scrub" subcommand which, in user-land, finds and scrubs a pool. This has proven useful for experimenting with the scan logic (especially the in-order-scrub patches) without having to reload the kernel module and seems like it may be useful to others. Like the original PR openzfs#6209 - at this point, it is not yet ready to merge. There are no tests, no docs and so on... it's currently just a rebased PR openzfs#6209 But like @nwf - I am curious for anyone's commentary and/or suggestions. Signed-off-by: Tino Reichardt <[email protected]> Signed-off-by: Nathaniel Wesley Filardo <[email protected]>
|
Lack of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new zhack scrub sub command for zfs pool scrubbing within userspace.
Motivation and Context
#13618 (comment)
Description
This PR adds a "zhack scrub" subcommand which, in user-land, finds and
scrubs a pool. This has proven useful for experimenting with the scan
logic (especially the in-order-scrub patches) without having to reload
the kernel module and seems like it may be useful to others.
Like the original PR #6209 - at this point, it is not yet ready to
merge. There are no tests, no docs and so on... it's currently just a
rebased PR #6209
But like @nwf - I am curious for anyone's commentary and/or suggestions.
How Has This Been Tested?
Currently no testing at all ... just rebased for correct compiling.
Types of changes
Checklist:
Signed-off-by.