Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zhack scrub sub command for offline scrubs in userland #14036

Closed
wants to merge 2 commits into from

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Oct 16, 2022

This PR adds a new zhack scrub sub command for zfs pool scrubbing within userspace.

Motivation and Context

#13618 (comment)

Description

This PR adds a "zhack scrub" subcommand which, in user-land, finds and
scrubs a pool. This has proven useful for experimenting with the scan
logic (especially the in-order-scrub patches) without having to reload
the kernel module and seems like it may be useful to others.

Like the original PR #6209 - at this point, it is not yet ready to
merge. There are no tests, no docs and so on... it's currently just a
rebased PR #6209

But like @nwf - I am curious for anyone's commentary and/or suggestions.

How Has This Been Tested?

Currently no testing at all ... just rebased for correct compiling.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Signed-off-by: Tino Reichardt <[email protected]>
Signed-off-by: Nathaniel Wesley Filardo <[email protected]>
This PR adds a "zhack scrub" subcommand which, in user-land, finds and
scrubs a pool. This has proven useful for experimenting with the scan
logic (especially the in-order-scrub patches) without having to reload
the kernel module and seems like it may be useful to others.

Like the original PR openzfs#6209 - at this point, it is not yet ready to
merge. There are no tests, no docs and so on... it's currently just a
rebased  PR openzfs#6209

But like @nwf - I am curious for anyone's commentary and/or suggestions.

Signed-off-by: Tino Reichardt <[email protected]>
Signed-off-by: Nathaniel Wesley Filardo <[email protected]>
@mcmilk mcmilk marked this pull request as draft October 16, 2022 16:13
@mcmilk mcmilk deleted the branch openzfs:master October 16, 2022 16:16
@mcmilk mcmilk closed this Oct 16, 2022
@mcmilk mcmilk deleted the master branch October 16, 2022 16:16
@mcmilk mcmilk restored the master branch October 16, 2022 16:22
@mcmilk
Copy link
Contributor Author

mcmilk commented Oct 16, 2022

Ups ... I used master :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant