Add the zpool and filesystem versions to the printk loading message. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, I've applied it to master. The only change was I added the bulk of your comment above to the commit message. I'm a big fan of good commit messages, even for the cosmetic stuff. :) Commit a23cc0a |
prateekpandey14
pushed a commit
to prateekpandey14/zfs
that referenced
this pull request
Mar 13, 2019
Signed-off-by: Richard Elling <[email protected]>
sdimitro
pushed a commit
to sdimitro/zfs
that referenced
this pull request
Feb 14, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cosmetic patch that results in these dmesg lines:
ZFS: Loaded module v0.6.0, ZFS pool version 28, ZFS filesystem version 5
ZFS: Unloaded module v0.6.0
This change removes an ambiguity and adds information that system administrators care about. The phrase "ZFS pool version %s" is the same as
zpool upgrade -vso that the operator is familiar with the message.