Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1.5] FreeBSD: Fix translation from ABD to physical pages. #13358

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

amotin
Copy link
Member

@amotin amotin commented Apr 21, 2022

In hypothetical case of non-linear ABD with single segment, multiple
to page size but not aligned to it, vdev_geom_fill_unmap_cb() could
fill one page less into bio_ma array.

I am not sure it is expoitable, but better to be safe than sorry.

Reported-by: Mark Johnston [email protected]
(cherry picked from commit 5352f85)

Merge of #13345

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

In hypothetical case of non-linear ABD with single segment, multiple
to page size but not aligned to it, vdev_geom_fill_unmap_cb() could
fill one page less into bio_ma array.

I am not sure it is expoitable, but better to be safe than sorry.

Reported-by: Mark Johnston <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
(cherry picked from commit 5352f85)
@amotin amotin requested a review from behlendorf April 21, 2022 14:33
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Apr 21, 2022
@behlendorf behlendorf merged commit 972637d into openzfs:zfs-2.1.5-staging Apr 21, 2022
@amotin amotin deleted the unmap_cb_215 branch June 29, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants