ZTS Exceptions and minor scsi_debug improvements #13318

behlendorf · 2022-04-12T00:36:21Z

Motivation and Context

Update the test cases and related support infrastructure to accurately
reflect their status. For some tests this means allowing them to be
retried to minimize false positives in the CI.

Description

Additional detail in the individual commit messages.

6ee58ba ZTS: Retry auto_spare_multiple.ksh
dc34a5b ZTS: Wait for scsi_debug.ko
e28352c ZTS: Retry redundancy_draid_spare[1,3].ksh

How Has This Been Tested?

Locally by running the modified tests a few times.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Performance enhancement (non-breaking change which improves efficiency)
Code cleanup (non-breaking change which makes code smaller or more readable)
Breaking change (fix or feature that would cause existing functionality to change)
Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
Documentation (a change to man pages or other documentation)

Checklist:

My code follows the OpenZFS code style requirements.
I have updated the documentation accordingly.
I have read the contributing document.
I have added tests to cover my changes.
I have run the ZFS Test Suite with this change applied.
All commit messages are properly formatted and contain Signed-off-by.

The redundancy_draid_spare1.ksh and redundancy_draid_spare3.ksh test cases are a little to strict for the sequential resilver case. While unlikely it is possible that a handful of correctable checksum errors will be reported resulting in a test failure. Update the zts-report.py script to allow this the test case to be retried if requested. Signed-off-by: Brian Behlendorf <[email protected]>

It may take a few moments for scsi_debug devices to be reported by the lsscsi command. Wait for up to 30 seconds before reporting this as a failure to help avoid false positives in the CI. Additionally, when inserting a drive poll to ensure it's available. Signed-off-by: Brian Behlendorf <[email protected]>

The auto_spare_multiple.ksh test may incorrectly fail for a similar reason as the auto_spare_shared.ksh test. Add it to known list of exceptions which should be retried to prevent failures in the CI. Signed-off-by: Brian Behlendorf <[email protected]>

The auto_spare_multiple.ksh test may incorrectly fail for a similar reason as the auto_spare_shared.ksh test. Add it to known list of exceptions which should be retried to prevent failures in the CI. Reviewed-by: George Melikov <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes #13318

behlendorf · 2022-04-13T16:48:02Z

Merged except for the scsi_debug changes. That change needs a bit more work before merging.

The redundancy_draid_spare1.ksh and redundancy_draid_spare3.ksh test cases are a little to strict for the sequential resilver case. While unlikely it is possible that a handful of correctable checksum errors will be reported resulting in a test failure. Update the zts-report.py script to allow this the test case to be retried if requested. Reviewed-by: George Melikov <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#13318

The auto_spare_multiple.ksh test may incorrectly fail for a similar reason as the auto_spare_shared.ksh test. Add it to known list of exceptions which should be retried to prevent failures in the CI. Reviewed-by: George Melikov <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#13318