Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wunused-but-set-variable post-increments found by new Clang trunk (number 3 will shock you!) #13304

Closed
wants to merge 5 commits into from
Closed

-Wunused-but-set-variable post-increments found by new Clang trunk (number 3 will shock you!) #13304

wants to merge 5 commits into from

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented Apr 7, 2022 •
edited
Loading

Description

We provide no API for draid, it did nothing, and was undocumented.

num_indirect is a left-over from the original a1d477c; it's unused there as well.

zpool_clear_label() contains a bug-fix (since I assume failing to clear the L2ARC label should be an error) an optimisation, and a clean-up to match the bug-fix. The bug-fix is separate for backports.

How Has This Been Tested?

Builds.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – CI take my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@nabijaczleweli
tests: cmd: draid: remove unused and undocumented -v
babd545 
Found with -Wunused-but-set-variable on Clang trunk

Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
module: zfs: vdev_removal: remove unused num_indirect
718c0db 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
6b9898e 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli nabijaczleweli force-pushed the why-does-mom-let-you-play-with-new-clang branch from 158d8d0 to 741925e Compare April 11, 2022 13:33
behlendorf
behlendorf approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a trivial nit. It wouldn't hurt to rebase this too before merging.

lib/libzfs/libzfs_import.c Show resolved Hide resolved
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Apr 11, 2022
@nabijaczleweli nabijaczleweli force-pushed the why-does-mom-let-you-play-with-new-clang branch from 741925e to d1bc3c6 Compare April 11, 2022 22:53
behlendorf pushed a commit that referenced this pull request Apr 13, 2022
@nabijaczleweli @behlendorf
module: zfs: vdev_removal: remove unused num_indirect
16c3290 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #13304
behlendorf pushed a commit that referenced this pull request Apr 13, 2022
@nabijaczleweli @behlendorf
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
a4e0cee 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #13304
behlendorf pushed a commit that referenced this pull request Apr 13, 2022
@nabijaczleweli @behlendorf
libzfs: import: zpool_clear_label: don't allocate another time for L2…
74e4bfb 
…ARC header

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #13304
behlendorf pushed a commit that referenced this pull request Apr 13, 2022
@nabijaczleweli @behlendorf
libzfs: import: zpool_clear_label: bool for boolean status
0dd34a1 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #13304
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this pull request Apr 13, 2022
@nabijaczleweli
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
2c534bb 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Upstream-commit: a4e0cee
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
@nabijaczleweli nabijaczleweli mentioned this pull request Apr 13, 2022
Merged
13 tasks
nabijaczleweli added a commit to nabijaczleweli/zfs that referenced this pull request Apr 13, 2022
@nabijaczleweli
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
03359e3 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Upstream-commit: a4e0cee
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
behlendorf pushed a commit that referenced this pull request Apr 15, 2022
@nabijaczleweli @behlendorf
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
ff23ef0 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Upstream-commit: a4e0cee
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #13304
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
tests: cmd: draid: remove unused and undocumented -v
72610f4 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
module: zfs: vdev_removal: remove unused num_indirect
7b6afde 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
649f268 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
libzfs: import: zpool_clear_label: don't allocate another time for L2…
037f5dc 
…ARC header

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
libzfs: import: zpool_clear_label: bool for boolean status
56dfe44 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
tests: cmd: draid: remove unused and undocumented -v
6328187 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
module: zfs: vdev_removal: remove unused num_indirect
26b4c30 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
e36a076 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
libzfs: import: zpool_clear_label: don't allocate another time for L2…
fc5f6f0 
…ARC header

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
libzfs: import: zpool_clear_label: bool for boolean status
35a8f7e 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 2, 2022
@nabijaczleweli @lundman
tests: cmd: draid: remove unused and undocumented -v
cccbc63 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 2, 2022
@nabijaczleweli @lundman
module: zfs: vdev_removal: remove unused num_indirect
89bbbfe 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
tests: cmd: draid: remove unused and undocumented -v
84139e5 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
module: zfs: vdev_removal: remove unused num_indirect
6f8af4a 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
d9863e6 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: don't allocate another time for L2…
6a92b11 
…ARC header

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: bool for boolean status
74e29c2 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
tests: cmd: draid: remove unused and undocumented -v
f3f9717 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
module: zfs: vdev_removal: remove unused num_indirect
3c71eb0 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
1f6af14 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: don't allocate another time for L2…
e6d59ec 
…ARC header

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: bool for boolean status
59e0aef 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
tests: cmd: draid: remove unused and undocumented -v
2a5f2fe 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
module: zfs: vdev_removal: remove unused num_indirect
6c8b5a6 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
de08898 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: don't allocate another time for L2…
89f16a5 
…ARC header

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: bool for boolean status
1668423 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
tests: cmd: draid: remove unused and undocumented -v
0f87328 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
module: zfs: vdev_removal: remove unused num_indirect
9d95100 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: actually fail if clearing l2arc he…
baa765c 
…ader fails

Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: don't allocate another time for L2…
73875aa 
…ARC header

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@nabijaczleweli @andrewc12
libzfs: import: zpool_clear_label: bool for boolean status
32853f2 
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
szubersk pushed a commit to szubersk/zfs that referenced this pull request Nov 16, 2022
@nabijaczleweli @szubersk
tests: cmd: draid: remove unused and undocumented -v
1b44c55 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
(cherry picked from commit 63cb341)
szubersk pushed a commit to szubersk/zfs that referenced this pull request Nov 16, 2022
@nabijaczleweli @szubersk
module: zfs: vdev_removal: remove unused num_indirect
67890d0 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
(cherry picked from commit 16c3290)
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 29, 2022
@nabijaczleweli @tonyhutter
tests: cmd: draid: remove unused and undocumented -v
93b1676 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 29, 2022
@nabijaczleweli @tonyhutter
module: zfs: vdev_removal: remove unused num_indirect
aa01f16 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 30, 2022
@nabijaczleweli @tonyhutter
tests: cmd: draid: remove unused and undocumented -v
e50862b 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 30, 2022
@nabijaczleweli @tonyhutter
module: zfs: vdev_removal: remove unused num_indirect
5f8f6db 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 1, 2022
@nabijaczleweli @tonyhutter
tests: cmd: draid: remove unused and undocumented -v
670d66e 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 1, 2022
@nabijaczleweli @tonyhutter
module: zfs: vdev_removal: remove unused num_indirect
32f7499 
Found with -Wunused-but-set-variable on Clang trunk

Fixes: a1d477c ("OpenZFS 7614, 9064 - zfs device evacuation/removal")
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
szubersk pushed a commit to szubersk/zfs that referenced this pull request Dec 7, 2022
@nabijaczleweli
tests: cmd: draid: remove unused and undocumented -v
4c7e231 
Found with -Wunused-but-set-variable on Clang trunk

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#13304
(cherry picked from commit 63cb341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabijaczleweli @behlendorf