Expose additional file level attributes #13118

usaleem-ix · 2022-02-18T19:04:55Z

Motivation and Context

Provide access to additional file level attributes on Linux.
FreeBSD already provides access to these attributes.

Description

ZFS allows to update and retrieve additional file level attributes for
FreeBSD. This commit allows additional file level attributes to be
updated and retrieved for Linux. These include the flags stored in the
upper half of z_pflags only.

Two new IOCTLs have been added for this purpose. ZFS_IOC_GETDOSFLAGS
can be used to retieve the attributes, while ZFS_IOC_SETDOSFLAGS can
be used to update the attributes.

Attributes that are allowed to be updated include ZFS_IMMUTABLE,
ZFS_APPENDONLY, ZFS_NOUNLINK, ZFS_ARCHIVE, ZFS_NODUMP, ZFS_SYSTEM,
ZFS_HIDDEN, ZFS_READONLY, ZFS_REPARSE, ZFS_OFFLINE and ZFS_SPARSE.
Flags can be or'd together while calling ZFS_IOC_SETDOSFLAGS.

How Has This Been Tested?

Two C programs have added to test the new IOCTLs on Linux.

"read_dos_attributes" performs ZFS_IOC_GETDOSFLAGS and a test case verifies the
command works successfully.

"write_dos_attributes" performs ZFS_IOC_SETDOSFLAGS and verifies that the
attribute has been set. A test case verifies the command works successfully.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Performance enhancement (non-breaking change which improves efficiency)
Code cleanup (non-breaking change which makes code smaller or more readable)
Breaking change (fix or feature that would cause existing functionality to change)
Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
Documentation (a change to man pages or other documentation)

Checklist:

My code follows the OpenZFS code style requirements.
I have updated the documentation accordingly.
I have read the contributing document.
I have added tests to cover my changes.
I have run the ZFS Test Suite with this change applied.
All commit messages are properly formatted and contain Signed-off-by.

ghost

One small change needed in the test program:

tests/zfs-tests/cmd/read_dos_attributes/read_dos_attributes.c

module/os/linux/zfs/zpl_file.c

include/sys/zfs_project.h

include/sys/zfs_znode.h

ghost · 2022-02-21T20:32:27Z

I just remembered we have some tests for dosflags we run on FreeBSD already, in tests/zfs-tests/tests/functional/acl/off/dosmode.ksh. I've asked Umer to generalize the test programs he wrote a bit so we can use them to run that test on Linux, too.

tests/runfiles/linux.run

ghost · 2022-03-01T00:28:05Z

Please rebase this on the current master as well when you update next.

usaleem-ix · 2022-03-01T09:32:05Z

Please rebase this on the current master as well when you update next.

Updated.

usaleem-ix · 2022-03-02T17:24:59Z

The CI failures seem unrelated.

behlendorf

Looks good. The CI failures here are unrelated.

amotin · 2022-03-02T18:20:33Z

module/os/linux/zfs/zpl_file.c

+	if ((ioctl_flags & ZFS_REPARSE)) {
+		XVA_SET_REQ(xva, XAT_REPARSE);
+		xoap->xoa_reparse = B_TRUE;
+	}


This code is effectively set-only. It may be OK for now, since XAT_REPARSE setting seem to return EPERM, but for general case I guess it may be broken.

Thank you for pointing it out @amotin. I am working on it.

@amotin updated to work for both set and unset.

amotin

The Linux code in _zpl_ioctl_setdosflags is different from respective code in FreeBSD. The last sets XAT* only for modified flags. That is the cause of the problem with XAT_REPARSE I mentioned above. While it is a minor issue for now, I'd prefer this to be sorted out.

module/os/linux/zfs/zpl_file.c

amotin

Thank you.

Divergence CHANGE_FLAG vs FLAG_CHANGE between OS is minor, but still not required.

module/os/linux/zfs/zpl_file.c

ZFS allows to update and retrieve additional file level attributes for FreeBSD. This commit allows additional file level attributes to be updated and retrieved for Linux. These include the flags stored in the upper half of z_pflags only. Two new IOCTLs have been added for this purpose. ZFS_IOC_GETDOSFLAGS can be used to retieve the attributes, while ZFS_IOC_SETDOSFLAGS can be used to update the attributes. Attributes that are allowed to be updated include ZFS_IMMUTABLE, ZFS_APPENDONLY, ZFS_NOUNLINK, ZFS_ARCHIVE, ZFS_NODUMP, ZFS_SYSTEM, ZFS_HIDDEN, ZFS_READONLY, ZFS_REPARSE, ZFS_OFFLINE and ZFS_SPARSE. Flags can be or'd together while calling ZFS_IOC_SETDOSFLAGS. Signed-off-by: Umer Saleem <[email protected]>

ZFS allows to update and retrieve additional file level attributes for FreeBSD. This commit allows additional file level attributes to be updated and retrieved for Linux. These include the flags stored in the upper half of z_pflags only. Two new IOCTLs have been added for this purpose. ZFS_IOC_GETDOSFLAGS can be used to retrieve the attributes, while ZFS_IOC_SETDOSFLAGS can be used to update the attributes. Attributes that are allowed to be updated include ZFS_IMMUTABLE, ZFS_APPENDONLY, ZFS_NOUNLINK, ZFS_ARCHIVE, ZFS_NODUMP, ZFS_SYSTEM, ZFS_HIDDEN, ZFS_READONLY, ZFS_REPARSE, ZFS_OFFLINE and ZFS_SPARSE. Flags can be or'd together while calling ZFS_IOC_SETDOSFLAGS. Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Umer Saleem <[email protected]> Closes openzfs#13118

behlendorf added the Status: Code Review Needed Ready for review and testing label Feb 18, 2022

ghost approved these changes Feb 18, 2022

View reviewed changes

ghost suggested changes Feb 18, 2022

View reviewed changes

tests/zfs-tests/cmd/read_dos_attributes/read_dos_attributes.c Outdated Show resolved Hide resolved

behlendorf reviewed Feb 19, 2022

View reviewed changes

module/os/linux/zfs/zpl_file.c Show resolved Hide resolved

include/sys/zfs_project.h Outdated Show resolved Hide resolved

usaleem-ix force-pushed the NAS-114369 branch 2 times, most recently from 32ea006 to 17875ce Compare February 21, 2022 12:14

usaleem-ix requested review from behlendorf and a user February 21, 2022 12:16

ghost reviewed Feb 21, 2022

View reviewed changes

include/sys/zfs_znode.h Outdated Show resolved Hide resolved

usaleem-ix force-pushed the NAS-114369 branch from 17875ce to db4c190 Compare February 21, 2022 17:18

usaleem-ix force-pushed the NAS-114369 branch from db4c190 to 6fb2bc0 Compare February 28, 2022 12:46

usaleem-ix requested a review from a user February 28, 2022 12:59

usaleem-ix force-pushed the NAS-114369 branch 2 times, most recently from 0220d5c to a96a20f Compare February 28, 2022 20:02

behlendorf reviewed Feb 28, 2022

View reviewed changes

tests/runfiles/linux.run Outdated Show resolved Hide resolved

usaleem-ix force-pushed the NAS-114369 branch from a96a20f to a1e02a6 Compare March 1, 2022 09:05

usaleem-ix requested a review from behlendorf March 1, 2022 09:33

ghost approved these changes Mar 2, 2022

View reviewed changes

behlendorf approved these changes Mar 2, 2022

View reviewed changes

behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 2, 2022

amotin reviewed Mar 2, 2022

View reviewed changes

amotin requested changes Mar 2, 2022

View reviewed changes

usaleem-ix force-pushed the NAS-114369 branch from a1e02a6 to 53f11c2 Compare March 2, 2022 21:35

usaleem-ix requested a review from amotin March 2, 2022 21:39

usaleem-ix commented Mar 2, 2022

View reviewed changes

module/os/linux/zfs/zpl_file.c Outdated Show resolved Hide resolved

usaleem-ix force-pushed the NAS-114369 branch from 53f11c2 to 237458b Compare March 3, 2022 11:02

usaleem-ix requested a review from behlendorf March 3, 2022 11:06

amotin approved these changes Mar 3, 2022

View reviewed changes

usaleem-ix force-pushed the NAS-114369 branch 2 times, most recently from 3b52e2d to 62cb64b Compare March 4, 2022 12:54

ghost reviewed Mar 4, 2022

View reviewed changes

module/os/linux/zfs/zpl_file.c Outdated Show resolved Hide resolved

usaleem-ix force-pushed the NAS-114369 branch from 62cb64b to 2f38cb2 Compare March 5, 2022 06:27

ghost approved these changes Mar 5, 2022

View reviewed changes

behlendorf approved these changes Mar 5, 2022

View reviewed changes

behlendorf merged commit 39a4daf into openzfs:master Mar 8, 2022

behlendorf mentioned this pull request Mar 23, 2022

Update mapping of file attributes/flags between linux and freebsd #11780

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose additional file level attributes #13118

Expose additional file level attributes #13118

usaleem-ix commented Feb 18, 2022

ghost left a comment

ghost commented Feb 21, 2022

ghost commented Mar 1, 2022

usaleem-ix commented Mar 1, 2022

usaleem-ix commented Mar 2, 2022

behlendorf left a comment

amotin Mar 2, 2022

usaleem-ix Mar 2, 2022

usaleem-ix Mar 2, 2022

amotin left a comment

amotin left a comment

Expose additional file level attributes #13118

Expose additional file level attributes #13118

Conversation

usaleem-ix commented Feb 18, 2022

Motivation and Context

Description

How Has This Been Tested?

Types of changes

Checklist:

ghost left a comment

Choose a reason for hiding this comment

ghost commented Feb 21, 2022

ghost commented Mar 1, 2022

usaleem-ix commented Mar 1, 2022

usaleem-ix commented Mar 2, 2022

behlendorf left a comment

Choose a reason for hiding this comment

amotin Mar 2, 2022

Choose a reason for hiding this comment

usaleem-ix Mar 2, 2022

Choose a reason for hiding this comment

usaleem-ix Mar 2, 2022

Choose a reason for hiding this comment

amotin left a comment

Choose a reason for hiding this comment

amotin left a comment

Choose a reason for hiding this comment