-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct compilation errors reported by GCC 10/11 #13103
Conversation
This breaks the build on FreeBSD, CC os/freebsd/libzfs_zmount.lo
os/freebsd/libzfs_compat.c:295:10: error: enumeration value 'ZFS_TYPE_INVALID' not handled in switch [-Werror,-Wswitch]
switch (zhp->zfs_type) { |
Thanks for spotting this! Corrected and rebased. As a bonus, I got rid of shadowed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for sorting this out.
@behlendorf, rebased. |
@behlendorf I found 2 more issues: one from Debian bullseye ASan+UBSan, the other one from Debian Bookworm. Most likely other would hit them soon. |
New `zfs_type_t` value `ZFS_TYPE_INVALID` is introduced. Variable initialization is now possible to make GCC happy. Close #12167. Signed-off-by: szubersk <[email protected]>
New `zfs_type_t` value `ZFS_TYPE_INVALID` is introduced. Variable initialization is now possible to make GCC happy. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#12167 Closes openzfs#13103
New `zfs_type_t` value `ZFS_TYPE_INVALID` is introduced. Variable initialization is now possible to make GCC happy. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#12167 Closes openzfs#13103
New `zfs_type_t` value `ZFS_TYPE_INVALID` is introduced. Variable initialization is now possible to make GCC happy. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#12167 Closes openzfs#13103
New `zfs_type_t` value `ZFS_TYPE_INVALID` is introduced. Variable initialization is now possible to make GCC happy. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#12167 Closes openzfs#13103
New `zfs_type_t` value `ZFS_TYPE_INVALID` is introduced. Variable initialization is now possible to make GCC happy. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#12167 Closes openzfs#13103
New `zfs_type_t` value `ZFS_TYPE_INVALID` is introduced. Variable initialization is now possible to make GCC happy. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#12167 Closes openzfs#13103
New `zfs_type_t` value `ZFS_TYPE_INVALID` is introduced. Variable initialization is now possible to make GCC happy. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#12167 Closes openzfs#13103
New `zfs_type_t` value `ZFS_TYPE_INVALID` is introduced. Variable initialization is now possible to make GCC happy. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#12167 Closes openzfs#13103
New `zfs_type_t` value `ZFS_TYPE_INVALID` is introduced. Variable initialization is now possible to make GCC happy. Reviewed by: Brian Behlendorf <[email protected]> Signed-off-by: szubersk <[email protected]> Closes openzfs#12167 Closes openzfs#13103
Motivation and Context
#12167
Description
New
zfs_type_t
valueZFS_TYPE_INVALID
is introduced.Variable initialization is now possible to make GCC happy.
Close #12167.
How Has This Been Tested?
$ make
Types of changes
Checklist:
Signed-off-by
.