Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dsl_dir_tempreserve_impl: remove unused deferred variable #13056

Merged
merged 1 commit into from
Feb 4, 2022
Merged

dsl_dir_tempreserve_impl: remove unused deferred variable #13056

merged 1 commit into from
Feb 4, 2022

Conversation

problame
Copy link
Contributor

@problame problame commented Feb 2, 2022

The following commit moved the users of unused into functino
dsl_pool_unreserved_space:

commit d2734cce68cf740e015312314415f9034c67851c
Author: Serapheim Dimitropoulos <[email protected]>
Date:   Fri Dec 16 14:11:29 2016 -0800

    OpenZFS 9166 - zfs storage pool checkpoint

Signed-off-by: Christian Schwarz [email protected]

ghost
ghost approved these changes Feb 2, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: There are some typos in the commit message it would be nice to fix. In particular I think you meant deferred rather than unused in the body.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Feb 2, 2022
@behlendorf behlendorf requested a review from sdimitro February 3, 2022 21:17
@cschwarz-nutanix
dsl_dir_tempreserve_impl: remove unused deferred variable
db01402 
The following commit moved the users of `deferred` into function
dsl_pool_unreserved_space:

    commit d2734cc
    Author: Serapheim Dimitropoulos <[email protected]>
    Date:   Fri Dec 16 14:11:29 2016 -0800

        OpenZFS 9166 - zfs storage pool checkpoint

Signed-off-by: Christian Schwarz <[email protected]>
@problame problame force-pushed the zfs-upstream-dir-tempreserve-unused-deferred branch from de4a1de to db01402 Compare February 4, 2022 15:15
@problame
Copy link
Contributor Author

problame commented Feb 4, 2022

nit: There are some typos in the commit message it would be nice to fix. In particular I think you meant deferred rather than unused in the body.

Thanks @freqlabs , did that, and only that, in the force push.

@behlendorf behlendorf merged commit db87580 into openzfs:master Feb 4, 2022
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 15, 2022
@cschwarz-nutanix @tonyhutter
dsl_dir_tempreserve_impl: remove unused deferred variable
44bfe11 
The following commit moved the users of `deferred` into function
dsl_pool_unreserved_space:

    commit d2734cc
    Author: Serapheim Dimitropoulos <[email protected]>
    Date:   Fri Dec 16 14:11:29 2016 -0800

        OpenZFS 9166 - zfs storage pool checkpoint

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Christian Schwarz <[email protected]>
Closes openzfs#13056
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 16, 2022
@cschwarz-nutanix @tonyhutter
dsl_dir_tempreserve_impl: remove unused deferred variable
9f4538d 
The following commit moved the users of `deferred` into function
dsl_pool_unreserved_space:

    commit d2734cc
    Author: Serapheim Dimitropoulos <[email protected]>
    Date:   Fri Dec 16 14:11:29 2016 -0800

        OpenZFS 9166 - zfs storage pool checkpoint

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Christian Schwarz <[email protected]>
Closes openzfs#13056
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 17, 2022
@cschwarz-nutanix @tonyhutter
dsl_dir_tempreserve_impl: remove unused deferred variable
a61915e 
The following commit moved the users of `deferred` into function
dsl_pool_unreserved_space:

    commit d2734cc
    Author: Serapheim Dimitropoulos <[email protected]>
    Date:   Fri Dec 16 14:11:29 2016 -0800

        OpenZFS 9166 - zfs storage pool checkpoint

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Christian Schwarz <[email protected]>
Closes openzfs#13056
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@cschwarz-nutanix @nicman23
dsl_dir_tempreserve_impl: remove unused deferred variable
3709df0 
The following commit moved the users of `deferred` into function
dsl_pool_unreserved_space:

    commit d2734cc
    Author: Serapheim Dimitropoulos <[email protected]>
    Date:   Fri Dec 16 14:11:29 2016 -0800

        OpenZFS 9166 - zfs storage pool checkpoint

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Christian Schwarz <[email protected]>
Closes openzfs#13056
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@cschwarz-nutanix @nicman23
dsl_dir_tempreserve_impl: remove unused deferred variable
7a9f9fc 
The following commit moved the users of `deferred` into function
dsl_pool_unreserved_space:

    commit d2734cc
    Author: Serapheim Dimitropoulos <[email protected]>
    Date:   Fri Dec 16 14:11:29 2016 -0800

        OpenZFS 9166 - zfs storage pool checkpoint

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Christian Schwarz <[email protected]>
Closes openzfs#13056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@behlendorf behlendorf behlendorf approved these changes

@sdimitro sdimitro Awaiting requested review from sdimitro

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@problame @behlendorf @gmelikov @cschwarz-nutanix