-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux 5.17 compat: PDE_DATA() renamed to pde_data() #13007
Conversation
527b30e
to
0fd57a1
Compare
Thanks, I'll test this out tonight |
I'm still seeing this error locally:
(For what it is worth I am building the kernel module on a 5.16.2 system using dkms pointing to the 5.17 headers...) |
cef7b3d
to
5453de7
Compare
uhoh, yeah, I didn't look hard enough and didn't notice the already-present PDE_DATA() config hunk; fixed, and actually passes on the buildd too now :) – please try again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
5453de7
to
8a25109
Compare
Upstream commit 359745d78351c6f5442435f81549f0207ece28aa ("proc: remove PDE_DATA() completely") Link: https://lore.kernel.org/all/[email protected]/T/#u Closes: openzfs#13004 Signed-off-by: Ahelenia Ziemiańska <[email protected]>
8a25109
to
8c7a938
Compare
That works! |
I suspect that this works, but there also seems to be another likely unrelated regression introduced by 5.17 that is causing the build to fail on my system, so I cannot run-time test it until that's fixed too. This does seem to properly address the PDE_DATA changes though. |
Picked on top of #12989 |
Motivation and Context
#13004
How Has This Been Tested?
Local build for pre-5.17, CI for 5.17.
Types of changes
Checklist:
Signed-off-by
.