Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-Wunused-but-set-variables caught by CI #12917

Closed
wants to merge 3 commits into from
Closed

-Wunused-but-set-variables caught by CI #12917

wants to merge 3 commits into from

Conversation

nabijaczleweli
Copy link
Contributor

Motivation and Context

Some more unused-but-set variables

Description

http://build.zfsonlinux.org/builders/FreeBSD%20stable%2F13%20amd64%20%28TEST%29/builds/3074/steps/shell_1/logs/make

How Has This Been Tested?

Builds, I think?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – CI take my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@szubersk
Copy link
Contributor

szubersk commented Jan 1, 2022

I wouldn't like to discourage from making such changes but if they are not backed up by an introduction of a permanent CI check (e. g. making FreeBSD stable/13 amd64 (TEST) required) soldifying the status quo, those kind of problems are very likely to come back again unnoticed (been there, seen that).

@nabijaczleweli
Copy link
Contributor Author

I have that planned for a later round, yes

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jan 5, 2022
@behlendorf behlendorf closed this in 7c41df4 Jan 6, 2022
behlendorf pushed a commit that referenced this pull request Jan 6, 2022
@nabijaczleweli @behlendorf
fm: remove unused variables
c25e639 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12917
behlendorf pushed a commit that referenced this pull request Jan 6, 2022
@nabijaczleweli @behlendorf
zvol: remove unused variable
7c2eb1c 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12917
@behlendorf behlendorf mentioned this pull request Jan 6, 2022
Closed
13 tasks
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 7, 2022
@nabijaczleweli @mcmilk
zvol: remove unused variable
f6adcc5 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 7, 2022
@nabijaczleweli @mcmilk
fm: remove unused variables
ff3b666 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 7, 2022
@nabijaczleweli @mcmilk
zvol: remove unused variable
25dd3a8 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
zvol: remove unused variable
da169ab 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
fm: remove unused variables
1bbd269 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
zvol: remove unused variable
8051762 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
zvol: remove unused variable
56c5a76 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
fm: remove unused variables
d6c3cd6 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
zvol: remove unused variable
b191646 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
behlendorf pushed a commit that referenced this pull request May 2, 2022
@nabijaczleweli @behlendorf
zvol: remove unused variable
b8e1366 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12917
behlendorf pushed a commit that referenced this pull request May 2, 2022
@nabijaczleweli @behlendorf
fm: remove unused variables
a175fe8 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12917
behlendorf pushed a commit that referenced this pull request May 2, 2022
@nabijaczleweli @behlendorf
zvol: remove unused variable
9e68b73 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12917
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
zvol: remove unused variable
f984f02 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
fm: remove unused variables
3672d5e 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
zvol: remove unused variable
0bcb4a1 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
zvol: remove unused variable
6e32239 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
fm: remove unused variables
96e68ce 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
zvol: remove unused variable
fa6358a 
Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrens ahrens ahrens approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees

@mmaybee mmaybee

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabijaczleweli @szubersk @behlendorf @ahrens @mmaybee