Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icp: rip out the Solaris loadable module architecture, crypto and cryptadmin ioctl defs, SHA1 #12902

Closed
wants to merge 3 commits into from
Closed

icp: rip out the Solaris loadable module architecture, crypto and cryptadmin ioctl defs, SHA1 #12902

wants to merge 3 commits into from

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented Dec 22, 2021 •
edited
Loading

Motivation and Context

#12895

Description

#12901 part 1 and ioctl{,admin}.h but on top of master. Ended up trivial. Should be g2g and a relative no-brainer to pull in.

Three files out and -817 net! Approaching the ideal software volume with each passing day.
Another two out for -1617!

How Has This Been Tested?

Builds.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes. – none apply
  • I have run the ZFS Test Suite with this change applied. – CI take my hand
  • All commit messages are properly formatted and contain Signed-off-by.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 22, 2021
@nabijaczleweli nabijaczleweli changed the title icp: rip out the Solaris loadable module architecture icp: rip out the Solaris loadable module architecture, crypto and cryptadmin ioctl defs Dec 23, 2021
@nabijaczleweli nabijaczleweli force-pushed the These-are-the-commands-supported-by-the-modctl-system-call_raw_1 branch from f02f79f to 21ad8cc Compare December 23, 2021 20:06
@nabijaczleweli
Copy link
Contributor Author

Rebased

@nabijaczleweli nabijaczleweli force-pushed the These-are-the-commands-supported-by-the-modctl-system-call_raw_1 branch 2 times, most recently from 8c338b2 to 56b9299 Compare December 23, 2021 22:53
nabijaczleweli and others added 3 commits January 5, 2022 17:01
@nabijaczleweli
module: icp: rip out the Solaris loadable module architecture
8e0b88a 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Ref: openzfs#12895
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
module: icp: remove solaris crypto and cryptoadm ioctl definitions
238da95 
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@mcmilk @nabijaczleweli
Remove sha1 hashing from OpenZFS, it's not used anywhere.
913b39c 
Signed-off-by: Tino Reichardt <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli nabijaczleweli force-pushed the These-are-the-commands-supported-by-the-modctl-system-call_raw_1 branch from 56b9299 to 913b39c Compare January 5, 2022 16:05
@nabijaczleweli
Copy link
Contributor Author

nabijaczleweli commented Jan 5, 2022 •
edited
Loading

Rebased, cherry-picked in the -3624-only sha1 removal – this remains trivial and obvious to pull in.

@nabijaczleweli nabijaczleweli changed the title icp: rip out the Solaris loadable module architecture, crypto and cryptadmin ioctl defs icp: rip out the Solaris loadable module architecture, crypto and cryptadmin ioctl defs, sha1 Jan 5, 2022
@nabijaczleweli nabijaczleweli changed the title icp: rip out the Solaris loadable module architecture, crypto and cryptadmin ioctl defs, sha1 icp: rip out the Solaris loadable module architecture, crypto and cryptadmin ioctl defs, SHA1 Jan 5, 2022
AttilaFueloep
AttilaFueloep approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@AttilaFueloep AttilaFueloep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 6, 2022
@behlendorf behlendorf closed this in 5c8389a Jan 7, 2022
behlendorf pushed a commit that referenced this pull request Jan 7, 2022
@nabijaczleweli @behlendorf
module: icp: remove solaris crypto and cryptoadm ioctl definitions
3e310f0 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12895
Closes #12902
behlendorf pushed a commit that referenced this pull request Jan 7, 2022
@mcmilk @behlendorf
Remove sha1 hashing from OpenZFS, it's not used anywhere.
a798b48 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12895
Closes #12902
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 7, 2022
@nabijaczleweli @mcmilk
module: icp: rip out the Solaris loadable module architecture
4564e44 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12895
Closes openzfs#12902
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 7, 2022
@nabijaczleweli @mcmilk
module: icp: remove solaris crypto and cryptoadm ioctl definitions
4cf7c73 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12895
Closes openzfs#12902
mcmilk added a commit to mcmilk/zfs that referenced this pull request Jan 7, 2022
@mcmilk
Remove sha1 hashing from OpenZFS, it's not used anywhere.
ec831e3 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12895
Closes openzfs#12902
@nabijaczleweli nabijaczleweli mentioned this pull request Jan 15, 2022
Closed
13 tasks
@nabijaczleweli nabijaczleweli mentioned this pull request Mar 11, 2022
Closed
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Jul 15, 2022
@mcmilk @rincebrain
Remove sha1 hashing from OpenZFS, it's not used anywhere.
639d816 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12895
Closes openzfs#12902
Signed-off-by: Rich Ercolani <[email protected]>
behlendorf pushed a commit that referenced this pull request Jul 26, 2022
@mcmilk @behlendorf
Remove sha1 hashing from OpenZFS, it's not used anywhere.
4b09770 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12895
Closes #12902
Signed-off-by: Rich Ercolani <[email protected]>
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
module: icp: rip out the Solaris loadable module architecture
3399eb5 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12895
Closes openzfs#12902
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
module: icp: remove solaris crypto and cryptoadm ioctl definitions
0f1d8a4 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12895
Closes openzfs#12902
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@mcmilk @nicman23
Remove sha1 hashing from OpenZFS, it's not used anywhere.
b1f7cfc 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12895
Closes openzfs#12902
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
module: icp: rip out the Solaris loadable module architecture
547b13e 
After progressively folding away null cases, it turns out there's
/literally/ nothing there, even if some things are part of the
Solaris SPARC DDI/DKI or the seventeen module types (some doubled for
32-bit userland), or the entire modctl syscall definition.
Nothing.

Initialisation is handled in illumos-crypto.c,
which calls all the initialisers directly

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12895
Closes openzfs#12902
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@nabijaczleweli @nicman23
module: icp: remove solaris crypto and cryptoadm ioctl definitions
384b632 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12895
Closes openzfs#12902
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@mcmilk @nicman23
Remove sha1 hashing from OpenZFS, it's not used anywhere.
e48510f 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Attila Fülöp <[email protected]>
Signed-off-by: Tino Reichardt <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12895
Closes openzfs#12902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AttilaFueloep AttilaFueloep AttilaFueloep approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees

@tonynguien tonynguien

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabijaczleweli @behlendorf @AttilaFueloep @tonynguien @mcmilk