Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: rsend tests #12876

Closed
wants to merge 2 commits into from
Closed

ZTS: rsend tests #12876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef6dda8
ZTS: rsend_007_pos failures
behlendorf Dec 17, 2021
c565cae
ZTS: speed up rsend tests
behlendorf Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions tests/test-runner/bin/zts-report.py.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,12 +250,6 @@ maybe = {
'removal/removal_condense_export': ['FAIL', known_reason],
'reservation/reservation_008_pos': ['FAIL', '7741'],
'reservation/reservation_018_pos': ['FAIL', '5642'],
'rsend/rsend_019_pos': ['FAIL', '6086'],
'rsend/rsend_020_pos': ['FAIL', '6446'],
'rsend/rsend_021_pos': ['FAIL', '6446'],
'rsend/rsend_024_pos': ['FAIL', '5665'],
'rsend/send-c_volume': ['FAIL', '6087'],
'rsend/send_partial_dataset': ['FAIL', known_reason],
'snapshot/clone_001_pos': ['FAIL', known_reason],
'snapshot/snapshot_009_pos': ['FAIL', '7961'],
'snapshot/snapshot_010_pos': ['FAIL', '7961'],
Expand Down Expand Up @@ -301,9 +295,6 @@ elif sys.platform.startswith('linux'):
'mmp/mmp_exported_import': ['FAIL', known_reason],
'mmp/mmp_inactive_import': ['FAIL', known_reason],
'refreserv/refreserv_raidz': ['FAIL', known_reason],
'rsend/rsend_007_pos': ['FAIL', known_reason],
'rsend/rsend_010_pos': ['FAIL', known_reason],
'rsend/rsend_011_pos': ['FAIL', known_reason],
'snapshot/rollback_003_pos': ['FAIL', known_reason],
'zvol/zvol_misc/zvol_misc_snapdev': ['FAIL', '12621'],
'zvol/zvol_misc/zvol_misc_volmode': ['FAIL', known_reason],
Expand Down
1 change: 1 addition & 0 deletions tests/zfs-tests/tests/functional/rsend/rsend.kshlib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ function cleanup_pool
log_must rm -rf $BACKDIR/*

if is_global_zone ; then
log_must df >/dev/null
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this some magic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's terrible, terrible black magic. I'm not sure why it avoids the issue, but it does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #12898 for the reason this works. I've used that PR to add a comment here which references the root issue, at least until it's properly addressed.

log_must_busy zfs destroy -Rf $pool
else
typeset list=$(zfs list -H -r -t all -o name $pool)
Expand Down
2 changes: 1 addition & 1 deletion tests/zfs-tests/tests/functional/rsend/send-c_verify_ratio.ksh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ log_assert "Verify send -c streams are compressed"
log_onexit cleanup_pool $POOL2

typeset sendfs=$POOL2/$FS
typeset megs=128
typeset megs=64

for prop in "${compress_prop_vals[@]}"; do
for compressible in 'yes' 'no'; do
Expand Down
6 changes: 1 addition & 5 deletions tests/zfs-tests/tests/functional/rsend/send_realloc_encrypted_files.ksh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,8 @@ if is_kmemleak; then
# to avoid timeout due to reduced performance.
nr_files=100
passes=2
elif is_freebsd; then
# Use fewer files and passes on FreeBSD to avoid timeout.
nr_files=500
passes=2
else
nr_files=1000
nr_files=300
passes=3
fi

Expand Down
6 changes: 1 addition & 5 deletions tests/zfs-tests/tests/functional/rsend/send_realloc_files.ksh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,8 @@ if is_kmemleak; then
# to avoid timeout due to reduced performance.
nr_files=100
passes=2
elif is_freebsd; then
# Use fewer passes and files on FreeBSD to avoid timeout.
nr_files=500
passes=2
else
nr_files=1000
nr_files=300
passes=3
fi

Expand Down