Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: alloc_class.ksh must wait for the process to exit #12873

Merged
merged 1 commit into from
Dec 17, 2021
Merged

ZTS: alloc_class.ksh must wait for the process to exit #12873

merged 1 commit into from
Dec 17, 2021

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Several alloc_class tests were semi-reliably failing on Ubuntu
20.04 due to this issue.

Description

The alloc_class_* tests may fail on Linux with an EBUSY error if
zfs destroy is run before the dd process has had a chance to
terminate. Wait on the pid after the kill -9 to make sure.

When testing I didn't observe any failures for the alloc_class
tests. Remove them from the exceptions list, the CI can verify
they are passing on all platforms.

How Has This Been Tested?

Locally run the alloc_class test group. Verified all tests pass.
I'm relying on the CI to verify these tests now pass on all
platforms reliably. If not, we can keep the needed exceptions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 16, 2021
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 17, 2021
@behlendorf behlendorf added the Component: Test Suite Indicates an issue with the test framework or a test case label Dec 17, 2021
@behlendorf
ZTS: alloc_class.ksh must wait for the process to exit
8d95025 
The alloc_class_* tests may fail on Linux with an EBUSY error if
`zfs destroy` is run before the `dd` process has had a chance to
terminate.  Wait on the pid after the `kill -9` to make sure.

When testing I didn't observe any failures for the alloc_class
tests.  Remove them from the exceptions list, the CI was used to
verify the tests pass on all platforms.

Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#11888
@behlendorf behlendorf merged commit eecd3f1 into openzfs:master Dec 17, 2021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 10, 2022
@behlendorf @tonyhutter
ZTS: alloc_class.ksh must wait for the process to exit
fe8b0a3 
The alloc_class_* tests may fail on Linux with an EBUSY error if
`zfs destroy` is run before the `dd` process has had a chance to
terminate.  Wait on the pid after the `kill -9` to make sure.

When testing I didn't observe any failures for the alloc_class
tests.  Remove them from the exceptions list, the CI was used to
verify the tests pass on all platforms.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Rich Ercolani <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12873
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@behlendorf @nicman23
ZTS: alloc_class.ksh must wait for the process to exit
1c73d7f 
The alloc_class_* tests may fail on Linux with an EBUSY error if
`zfs destroy` is run before the `dd` process has had a chance to
terminate.  Wait on the pid after the `kill -9` to make sure.

When testing I didn't observe any failures for the alloc_class
tests.  Remove them from the exceptions list, the CI was used to
verify the tests pass on all platforms.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Rich Ercolani <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12873
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@behlendorf @nicman23
ZTS: alloc_class.ksh must wait for the process to exit
2a46bc1 
The alloc_class_* tests may fail on Linux with an EBUSY error if
`zfs destroy` is run before the `dd` process has had a chance to
terminate.  Wait on the pid after the `kill -9` to make sure.

When testing I didn't observe any failures for the alloc_class
tests.  Remove them from the exceptions list, the CI was used to
verify the tests pass on all platforms.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Rich Ercolani <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwk404 jwk404 jwk404 approved these changes

@rincebrain rincebrain rincebrain approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @rincebrain @jwk404