Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: deadman_sync fix #12625

Merged
merged 1 commit into from
Oct 11, 2021
Merged

ZTS: deadman_sync fix #12625

merged 1 commit into from
Oct 11, 2021

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

http://build.zfsonlinux.org/builders/FreeBSD%20stable%2F12%20amd64%20%28TEST%29/builds/6511/steps/shell_4/logs/summary

Description

In the CI environment it's possible for events to be slightly
delayed resulting in 4, instead of 5 events, appearing in the
log file. This isn't a problem and should be considered a
success to avoid false positive test results.

How Has This Been Tested?

Visually inspected, to be verified by the CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

In the CI environment it's possible for events to be slightly
delayed resulting in 4, instead of 5 events, appearing in the
log file.  This isn't a problem and should be considered a
success to avoid false positive test results.

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Oct 8, 2021
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 11, 2021
@behlendorf behlendorf merged commit 72f06d0 into openzfs:master Oct 11, 2021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Mar 7, 2022
In the CI environment it's possible for events to be slightly
delayed resulting in 4, instead of 5, events appearing in the
log file.  This isn't a problem and should be considered a
success to avoid false positive test results.

Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#12625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants