initramfs: use correct dataset for rootfs on rollback=1 #12586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Sep 28, 2021
behlendorf
added
Status: Accepted
jwk404
approved these changes
Oct 6, 2021
|
@nachtgeist this looks good to me. Could you please force push once more, with a |
fixes openzfs#12585 Signed-off-by: Daniel Reichelt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When booting with
root=zfs:rpool/myrootfs@foosnapshot rollback=1,myrootfsand its descendants get rolled back tofoosnapshot, howeverZFS_BOOTFSstill containsmyrootfs@foosnapshotinstead of the actually desired value ofmyrootfs.fixes #12585
How Has This Been Tested?
Tested on Debian VMs using buster and bullseye (current stable and oldstable)
Types of changes