Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libspl: fix warning about missing spl_pagesize declaration #12567

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

ericonr
Copy link
Contributor

@ericonr ericonr commented Sep 16, 2021

Though it's unlikely anyone will alter its signature, avoids any
possible type mismatch.

Motivation and Context

Noticed warning while building, but it's always been there I think.

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Though it's unlikely anyone will alter its signature, avoids any
possible type mismatch.

Signed-off-by: Érico Nogueira <[email protected]>
@behlendorf
Copy link
Contributor

Makes sense, interestingly I don't think I've seen this warning. What environment are you seeing this in (distribution, compiler, etc)?

@ericonr
Copy link
Contributor Author

ericonr commented Sep 18, 2021

Building zfs 2.1.1 on Void Linux, using a snapshot of GCC 10.2.x branch (as snapshotted by alpine). musl libc too, but I don't think it matters here. No CFLAGS I can think of that'd affect the results here.

@behlendorf behlendorf added the Type: Building Indicates an issue related to building binaries label Sep 20, 2021
Copy link
Contributor

@tonynguien tonynguien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 21, 2021
@tonynguien tonynguien merged commit ce2bdce into openzfs:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants