Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fresh libabigail + minimize .abi files inconsistency #12529

Closed
wants to merge 5 commits into from

Conversation

gmelikov
Copy link
Member

@gmelikov gmelikov commented Aug 31, 2021

Motivation and Context

How Has This Been Tested?

sh ./autogen.sh
./configure
sudo docker run -it --rm -v $(pwd):/source gmelikov/libabigail make storeabi

, and in CI https://github.com/gmelikov/zfs/actions/runs/1187475483

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@jwk404 jwk404 requested a review from behlendorf September 1, 2021 16:40
@jwk404 jwk404 added the Status: Code Review Needed Ready for review and testing label Sep 1, 2021
We need to use 1.8.0+ version, older versions
may segfault and give inconsistent results.

Signed-off-by: George Melikov <[email protected]>
We use docker image instead.

Signed-off-by: George Melikov <[email protected]>
@jwk404 jwk404 added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 2, 2021
@jwk404
Copy link
Contributor

jwk404 commented Sep 2, 2021

@gmelikov If you could please squash these commits I'll get this merged.

@gmelikov
Copy link
Member Author

gmelikov commented Sep 2, 2021

@jwk404 I propose to merge them as is separately, they are atomic, self-explained and there is a large ugly commit with abi files.

@jwk404
Copy link
Contributor

jwk404 commented Sep 2, 2021

@jwk404 I propose to merge them as is separately, they are atomic, self-explained and there is a large ugly commit with abi files.

That's fine.

@behlendorf behlendorf closed this in a9655fc Sep 2, 2021
behlendorf pushed a commit that referenced this pull request Sep 2, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes #12529
behlendorf pushed a commit that referenced this pull request Sep 2, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes #12529
behlendorf pushed a commit that referenced this pull request Sep 2, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes #12529
behlendorf pushed a commit that referenced this pull request Sep 2, 2021
We use docker image instead.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes #12529
@gmelikov gmelikov deleted the abi_ci branch September 2, 2021 17:37
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
We need to use 1.8.0+ version, older versions
may segfault and give inconsistent results.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
We use docker image instead.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
We need to use 1.8.0+ version, older versions
may segfault and give inconsistent results.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
We use docker image instead.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
We use docker image instead.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
We use docker image instead.

Reviewed-by: John Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Melikov <[email protected]>
Closes openzfs#12529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants