Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unfortunate NULL in spa_update_dspace #12428

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Fix unfortunate NULL in spa_update_dspace #12428

merged 1 commit into from
Jul 26, 2021

Conversation

rincebrain
Copy link
Contributor

Motivation and Context

After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Description

Just the trivial NULL check.

How Has This Been Tested?

Not claiming to be deeply familiar with the code, but I couldn't visibly make it produce adverse or surprising outcomes in loops of testing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@rincebrain rincebrain force-pushed the dspace2 branch 2 times, most recently from c08a8e7 to 4791a8d Compare July 24, 2021 22:38
@jwk404 jwk404 requested review from mmaybee and ahrens July 25, 2021 18:46
@behlendorf behlendorf self-assigned this Jul 25, 2021
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jul 25, 2021
ahrens
ahrens approved these changes Jul 25, 2021
View reviewed changes
module/zfs/spa_misc.c Show resolved Hide resolved
@rincebrain
Fix unfortunate NULL in spa_update_dspace
7423255 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Closes openzfs#12380

Signed-off-by: Rich Ercolani <[email protected]>
@behlendorf behlendorf merged commit f1ca799 into openzfs:master Jul 26, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 23, 2021
@rincebrain @behlendorf
Fix unfortunate NULL in spa_update_dspace
6ec713c 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12380 
Closes openzfs#12428
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@rincebrain @behlendorf
Fix unfortunate NULL in spa_update_dspace
93bf3e8 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12380 
Closes openzfs#12428
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@rincebrain
Fix unfortunate NULL in spa_update_dspace
d65dc3d 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12380 
Closes openzfs#12428
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Aug 24, 2021
@rincebrain @behlendorf
Fix unfortunate NULL in spa_update_dspace
f7b2b2d 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12380
Closes openzfs#12428
rincebrain added a commit to rincebrain/zfs that referenced this pull request Aug 26, 2021
@rincebrain
Fix unfortunate NULL in spa_update_dspace
8e19712 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12380 
Closes openzfs#12428
behlendorf pushed a commit that referenced this pull request Aug 30, 2021
@rincebrain @behlendorf
Fix unfortunate NULL in spa_update_dspace
72b8210 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes #12380 
Closes #12428
behlendorf pushed a commit that referenced this pull request Aug 31, 2021
@rincebrain @behlendorf
Fix unfortunate NULL in spa_update_dspace
d753118 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes #12380
Closes #12428
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 15, 2021
@rincebrain @tonyhutter
Fix unfortunate NULL in spa_update_dspace
6385f4e 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12380
Closes openzfs#12428
tonyhutter pushed a commit that referenced this pull request Sep 22, 2021
@rincebrain @tonyhutter
Fix unfortunate NULL in spa_update_dspace
05c96b4 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes #12380 
Closes #12428
datacore-rm pushed a commit to DataCoreSoftware/openzfs that referenced this pull request Oct 4, 2022
@rincebrain @datacore-rm
Fix unfortunate NULL in spa_update_dspace
1e35ecf 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12380 
Closes openzfs#12428
datacore-rm pushed a commit to DataCoreSoftware/openzfs that referenced this pull request Oct 13, 2022
@rincebrain @datacore-rm
Fix unfortunate NULL in spa_update_dspace
61b3481 
After 1325434, we can in certain circumstances end up calling
spa_update_dspace with vd->vdev_mg NULL, which ends poorly during
vdev removal.

So let's not do that further space adjustment when we can't.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rich Ercolani <[email protected]>
Closes openzfs#12380 
Closes openzfs#12428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrens ahrens ahrens approved these changes

@behlendorf behlendorf behlendorf approved these changes

@mmaybee mmaybee Awaiting requested review from mmaybee

Assignees

@behlendorf behlendorf

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rincebrain @behlendorf @ahrens