Fix zpool on zvol deadlock #1220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 65d5608 fixes the lock inversion between spa_namespace_lock and bdev->bd_mutex but only for the first user of spa_namespace_lock: dmu_objset_own. Later spa_namespace_lock gets acquired by dsl_prop_get_integer (dsl_prop_get->dsl_dataset_hold->dsl_dir_open_spa->spa_open->spa_open_common) without this "protection". By moving the mutex release after this second use, even this acquisition of the lock is "protected" by the ERESTARTSYS trick. Author: Massimo Maggi <[email protected]>
|
@maxximino Thank you, looks good. babf3f9 Fix zpool on zvol deadlock |
unya
pushed a commit
to unya/zfs
that referenced
this pull request
Dec 13, 2013
Commit 65d5608 fixes the lock inversion between spa_namespace_lock and bdev->bd_mutex but only for the first user of spa_namespace_lock: dmu_objset_own(). Later spa_namespace_lock gets acquired by dsl_prop_get_integer() though dsl_prop_get()->dsl_dataset_hold()->dsl_dir_open_spa()-> spa_open()->spa_open_common() without this "protection". By moving the mutex release after this second use, even this acquisition of the lock is "protected" by the ERESTARTSYS trick. Signed-off-by: Massimo Maggi <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#1220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 65d5608 fixes the lock inversion
between spa_namespace_lock and bdev->bd_mutex but only for the first
user of spa_namespace_lock: dmu_objset_own. Later spa_namespace_lock
gets acquired by dsl_prop_get_integer
(dsl_prop_get->dsl_dataset_hold->dsl_dir_open_spa->spa_open->spa_open_common)
without this "protection". By moving the mutex release after this
second use, even this acquisition of the lock is "protected" by the
ERESTARTSYS trick.
zfs create mypool/internalpool -V 40G; zpool create intpool /dev/mypool/internalpool
was consistently failing for me, and now is consistently working.