Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variables caught by Clang 13 #12187

Closed
wants to merge 8 commits into from
Closed

Remove unused variables caught by Clang 13 #12187

wants to merge 8 commits into from

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented Jun 3, 2021 •
edited
Loading

Motivation and Context

warning :(

Description

Someone should look over these to see if they don't mask something.

How Has This Been Tested?

It builds?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jun 3, 2021
behlendorf
behlendorf approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look correct to me, although it's a little surprising we didn't get any compiler warnings about these unused variables until now.

@nabijaczleweli
Copy link
Contributor Author

HEAD Clang 13 has just grown vastly more aggressive tracing for this, it seems (so aggressive, in fact, that I got a few false positives in the qat dispatching code)

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jun 4, 2021
@mmaybee
Copy link
Contributor

mmaybee commented Jun 7, 2021

Please rebase and resolve merge conflicts

@nabijaczleweli
libzutil: zpool_find_config: remove unused variable
01e7c4b 
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
zdb: zdb_decompress_block: don't needlessly set buf
5401440 
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
libzfs: zfs_send: remove unused variable
803786f 
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
module/zfs: arc: arc_hdr_realloc_crypt: remove unused variables
d5be605 
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
module/zfs: dbuf: dbuf_read_impl: remove unused variable
d65bb5a 
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
module/zfs: vdev_indirect: vdev_indirect_repair: remove unused variable
ff054dd 
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
module/zfs: vdev_removal: spa_vdev_remove_thread: remove unused variable
e749645 
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
tests/file_check: remove unused variable
6fcc4a4 
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
@nabijaczleweli
Copy link
Contributor Author

Sure, rebased, but you will do well to note that there weren't any

@behlendorf behlendorf closed this in 77f3b67 Jun 8, 2021
behlendorf pushed a commit that referenced this pull request Jun 8, 2021
@nabijaczleweli @behlendorf
zdb: zdb_decompress_block: don't needlessly set buf
4f1009f 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request Jun 8, 2021
@nabijaczleweli @behlendorf
libzfs: zfs_send: remove unused variable
4ff49c5 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request Jun 8, 2021
@nabijaczleweli @behlendorf
module/zfs: arc: arc_hdr_realloc_crypt: remove unused variables
f719d3b 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request Jun 8, 2021
@nabijaczleweli @behlendorf
module/zfs: dbuf: dbuf_read_impl: remove unused variable
f70f3e2 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request Jun 8, 2021
@nabijaczleweli @behlendorf
module/zfs: vdev_indirect: vdev_indirect_repair: remove unused variable
6bab6ee 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request Jun 8, 2021
@nabijaczleweli @behlendorf
module/zfs: vdev_removal: spa_vdev_remove_thread: remove unused variable
f423411 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request Jun 8, 2021
@nabijaczleweli @behlendorf
tests/file_check: remove unused variable
9685f36 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 6, 2021
@nabijaczleweli @tonyhutter
tests/file_check: remove unused variable
ac9b1aa 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12187
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 6, 2021
@nabijaczleweli @tonyhutter
tests/file_check: remove unused variable
5ea770b 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12187
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
libzutil: zpool_find_config: remove unused variable
c633392 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12187
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
libzfs: zfs_send: remove unused variable
10b56c7 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12187
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
module/zfs: arc: arc_hdr_realloc_crypt: remove unused variables
500c690 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12187
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
module/zfs: dbuf: dbuf_read_impl: remove unused variable
e7842cc 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12187
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
module/zfs: vdev_indirect: vdev_indirect_repair: remove unused variable
c9ab143 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12187
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Apr 29, 2022
@nabijaczleweli @behlendorf
module/zfs: vdev_removal: spa_vdev_remove_thread: remove unused variable
526ec3f 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes openzfs#12187
behlendorf pushed a commit that referenced this pull request May 2, 2022
@nabijaczleweli @behlendorf
libzutil: zpool_find_config: remove unused variable
a1a54b3 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request May 2, 2022
@nabijaczleweli @behlendorf
libzfs: zfs_send: remove unused variable
116d447 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request May 2, 2022
@nabijaczleweli @behlendorf
module/zfs: arc: arc_hdr_realloc_crypt: remove unused variables
4149e19 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request May 2, 2022
@nabijaczleweli @behlendorf
module/zfs: dbuf: dbuf_read_impl: remove unused variable
18e9268 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request May 2, 2022
@nabijaczleweli @behlendorf
module/zfs: vdev_indirect: vdev_indirect_repair: remove unused variable
986d64c 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
behlendorf pushed a commit that referenced this pull request May 2, 2022
@nabijaczleweli @behlendorf
module/zfs: vdev_removal: spa_vdev_remove_thread: remove unused variable
7536ad3 
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
Closes #12187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

@mmaybee mmaybee

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabijaczleweli @mmaybee @behlendorf