-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple man-pages: Move to appropriate section #12149
Conversation
These manual pages belong in section 7 of the manual pages as that section, according to intro(7) on both FreeBSD and Linux, is meant to contain miscellaneous information pages whereas section 5 describes file formats (a good example being vdev_id.conf in zfs/man/man5/). While here, an errant space has also been removed. Signed-off-by: Daniel Ebdrup Jensen <[email protected]>
Address feedback by @jrtc27 Co-authored-by: Jessica Clarke <[email protected]>
I spotted a few missed cross references to the moved pages just in the diff context, so let's make sure to grep and get all of them. |
You're right, I missed quite a few. While here, I also noticed that I forgot some other things. |
Thanks. There are still 3 files renamed without changes, so they still have the old section number in them:
|
Ah, good catch! I have to admit that I wasn't aware of the .ST macro. |
Yeah, can we hold off on this until after #12125 and #12129 please? I touch all but two manpages (and rewrite some in parts or in full) in those and it was already a tremendous effort (and I don't say that lightly), and just rebasing that onto the new If you like, if you compile the list of renames from here I can run them myself after these land (which will be likely simpler to get right since most manpages properly |
Yeah, I can imagine, as that's quite a bit of work.
Sure, I don't mind as long as it gets done, that's what I care about. :) The files are:
This can also be seen by looking the subtractions in man5/Makefile.am and man8/Makefile.am here. Can I get a |
Sure thing |
Signed-off-by: Ahelenia Ziemiańska <[email protected]> Co-authored-by: Daniel Ebdrup Jensen <[email protected]> Closes openzfs#12149
Signed-off-by: Ahelenia Ziemiańska <[email protected]> Co-authored-by: Daniel Ebdrup Jensen <[email protected]> Closes openzfs#12149
Signed-off-by: Ahelenia Ziemiańska <[email protected]> Co-authored-by: Daniel Ebdrup Jensen <[email protected]> Closes openzfs#12149
Signed-off-by: Ahelenia Ziemiańska <[email protected]> Co-authored-by: Daniel Ebdrup Jensen <[email protected]> Closes openzfs#12149
@debdrup it'd be great to get your thoughts on the right location for some of these man pages. @nabijaczleweli posted a nice detailed #12196 (comment) which goes over rationals for various locations. |
The pages moved as follows: zpool-features.{5 => 7} spl{-module-parameters.5 => .4} zfs{-module-parameters.5 => .4} zfs-events.5 => into zpool-events.8 zfsconcepts.{8 => 7} zfsprops.{8 => 7} zpoolconcepts.{8 => 7} zpoolprops.{8 => 7} Signed-off-by: Ahelenia Ziemiańska <[email protected]> Co-authored-by: Daniel Ebdrup Jensen <[email protected]> Closes openzfs#12149
The pages moved as follows: zpool-features.{5 => 7} spl{-module-parameters.5 => .4} zfs{-module-parameters.5 => .4} zfs-events.5 => into zpool-events.8 zfsconcepts.{8 => 7} zfsprops.{8 => 7} zpoolconcepts.{8 => 7} zpoolprops.{8 => 7} Signed-off-by: Ahelenia Ziemiańska <[email protected]> Co-authored-by: Daniel Ebdrup Jensen <[email protected]> Closes openzfs#12149
The pages moved as follows: zpool-features.{5 => 7} spl{-module-parameters.5 => .4} zfs{-module-parameters.5 => .4} zfs-events.5 => into zpool-events.8 zfsconcepts.{8 => 7} zfsprops.{8 => 7} zpoolconcepts.{8 => 7} zpoolprops.{8 => 7} Signed-off-by: Ahelenia Ziemiańska <[email protected]> Co-authored-by: Daniel Ebdrup Jensen <[email protected]> Closes openzfs#12149
The pages moved as follows: zpool-features.{5 => 7} spl{-module-parameters.5 => .4} zfs{-module-parameters.5 => .4} zfs-events.5 => into zpool-events.8 zfsconcepts.{8 => 7} zfsprops.{8 => 7} zpoolconcepts.{8 => 7} zpoolprops.{8 => 7} Reviewed-by: Richard Laager <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Co-authored-by: Daniel Ebdrup Jensen <[email protected]> Closes openzfs#12149 Closes openzfs#12212
The pages moved as follows: zpool-features.{5 => 7} spl{-module-parameters.5 => .4} zfs{-module-parameters.5 => .4} zfs-events.5 => into zpool-events.8 zfsconcepts.{8 => 7} zfsprops.{8 => 7} zpoolconcepts.{8 => 7} zpoolprops.{8 => 7} Reviewed-by: Richard Laager <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Co-authored-by: Daniel Ebdrup Jensen <[email protected]> Closes openzfs#12149 Closes openzfs#12212
Motivation and Context
These manual pages belong in section 7 of the manual pages as that
section, according to intro(7) on both FreeBSD and Linux, is meant to
contain miscellaneous information pages whereas section 5 describes file
formats (a good example being vdev_id.conf in zfs/man/man5/).
While here, an errant space has also been removed.
Signed-off-by: Daniel Ebdrup Jensen [email protected]
How Has This Been Tested?
Mandoc has been run, but the change doesn't change a whole lot of roff formatting.
Types of changes
Checklist:
Signed-off-by
.