-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plymouth passphrase prompt with dracut #12147
Fix plymouth passphrase prompt with dracut #12147
Conversation
plymouth --command splits the command on spaces which means that zfs-load-key was getting the filesystem name enclosed in single quotes (since 13c59bb) and failing. This commit fixes it by piping the password directly to the command similar to how it's done in other scripts (initramfs, dracut without plymouth). Signed-off-by: Michal Vasilek <[email protected]> Related-to: openzfs#9193 Related-to: openzfs#9202
@belperite @ghfields I was hoping since you tackled a similar issue in #9202 I could convince you to review this related fix. |
Ping; I'm wondering if we should pull this patch for void-linux/void-packages#31644 |
If you can verify this does resolve the issue it should be safe to pull. If you are able to test it locally please let us know and we can pull it in as well, it's just been blocked on review/testing. |
Unfortunately, I don't use plymouth, but the change looks to work as intended. I'll let the Void PR gel for a few days in case those you tagged have a chance to review here, but I'm inclined to accept it unless you all discover something unexpected. |
i have strong doubts that this will work, as i've worked on this before for other projects, plymouth is particular about how this is done. |
This is known to work; as explained in the PR description, @paper42 has tested it on a physical device. |
Alright, we'll go ahead and move forward with this change. As mentioned in the PR description we've already made a very similar initramfs change for exactly this reason and it's been tested by the author. |
plymouth --command splits the command on spaces which means that zfs-load-key was getting the filesystem name enclosed in single quotes (since 13c59bb) and failing. This commit fixes it by piping the password directly to the command similar to how it's done in other scripts (initramfs, dracut without plymouth). Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Michal Vasilek <[email protected]> Related-to: openzfs#9193 Related-to: openzfs#9202 Closes openzfs#12147
Motivation and Context
When plymouth is in the initramfs generated by dracut, mounting an encrypted zfs filesystem results in an error
This is because plymouth --command is ran which splits the command on spaces which means that zfs-load-key gets the filesystem name enclosed in single quotes (since 13c59bb) and fails.
Similar issue with initramfs: #9193
Similar PR for initramfs where the issue with dracut was also discussed: #9202
Description
This commit fixes it by piping the password directly to the command similar to how it's done in other scripts (initramfs, dracut without plymouth).
How Has This Been Tested?
I tested this on my laptop both with plymouth in the initramfs and without.
Types of changes
Checklist:
Signed-off-by
.