Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix raw sends on encrypted datasets when copying back snapshots" #12033

Merged
merged 1 commit into from
May 13, 2021

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Issue #11294, #12025, #12300

Description

Commit d1d4769 takes into account the encryption key version to
decide if the local_mac could be zeroed out. However, this could lead
to failure mounting encrypted datasets created with intermediate
versions of ZFS encryption available in master between major releases.
In order to prevent this situation revert d1d4769 pending a more
comprehensive fix which addresses the mount failure case.

@gamanakis please review.

How Has This Been Tested?

This is a clean revert which was verified to resolve the mount failures
in the referenced issues.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 12, 2021
@behlendorf behlendorf self-assigned this May 12, 2021
Commit d1d4769 takes into account the encryption key version to
decide if the local_mac could be zeroed out. However, this could lead
to failure mounting encrypted datasets created with intermediate
versions of ZFS encyrption available in master between major releases.
In order to prevent this situtation revert d1d4769 pending a more
comprehensive fix which addresses the mount failure case.

Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#11294
Issue openzfs#12025
Issue openzfs#12300
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 13, 2021
@behlendorf behlendorf merged commit 6217656 into openzfs:master May 13, 2021
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request May 17, 2021
Commit d1d4769 takes into account the encryption key version to
decide if the local_mac could be zeroed out. However, this could lead
to failure mounting encrypted datasets created with intermediate
versions of ZFS encryption available in master between major releases.
In order to prevent this situation revert d1d4769 pending a more
comprehensive fix which addresses the mount failure case.

Reviewed-by: George Amanakis <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#11294
Issue openzfs#12025
Issue openzfs#12300
Closes openzfs#12033
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request May 17, 2021
Commit d1d4769 takes into account the encryption key version to
decide if the local_mac could be zeroed out. However, this could lead
to failure mounting encrypted datasets created with intermediate
versions of ZFS encryption available in master between major releases.
In order to prevent this situation revert d1d4769 pending a more
comprehensive fix which addresses the mount failure case.

Reviewed-by: George Amanakis <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#11294
Issue openzfs#12025
Issue openzfs#12300
Closes openzfs#12033
behlendorf added a commit to behlendorf/zfs that referenced this pull request May 28, 2021
Commit d1d4769 takes into account the encryption key version to
decide if the local_mac could be zeroed out. However, this could lead
to failure mounting encrypted datasets created with intermediate
versions of ZFS encryption available in master between major releases.
In order to prevent this situation revert d1d4769 pending a more
comprehensive fix which addresses the mount failure case.

Reviewed-by: George Amanakis <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#11294
Issue openzfs#12025
Issue openzfs#12300
Closes openzfs#12033
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Commit d1d4769 takes into account the encryption key version to
decide if the local_mac could be zeroed out. However, this could lead
to failure mounting encrypted datasets created with intermediate
versions of ZFS encryption available in master between major releases.
In order to prevent this situation revert d1d4769 pending a more
comprehensive fix which addresses the mount failure case.

Reviewed-by: George Amanakis <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Issue openzfs#11294
Issue openzfs#12025
Issue openzfs#12300
Closes openzfs#12033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants