zpool: use tab to intend continuation from removal status #11674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the output of the removal status in line with the other
"fields" that zpool status outputs, and thus allows an parser to
easier detect this as continuation of the 'remove:' output.
Before:
Now:
Signed-off-by: Thomas Lamprecht [email protected]
Motivation and Context
We have a parser for the zpool status output which uses the fact that continuations of output values over multiple lines uses a tab to intend those continuations, allowing detecting them relatively easily.
We got a report of a failure in said parser and when checking the offending
zpool status
output we saw that the removal status is not tab intended but used four space-characters, and was not covered by our testcases.After checking zpool status print code I figured this change would fit in and allow us to avoid special handling in the now relatively simple and general parser.
Description
Switch four spaces with a tab in two instances.
How Has This Been Tested?
Created a pool with a mirror, added an extra mirror and removed it again resulting in triggering the removal status code to print,
compared the output before and after.
Types of changes
Note, this can be probably seen as bug fix only in the widest sense, so please do not take above marking as such to serious.
Checklist:
Signed-off-by
.