Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum errors may not be counted #11609

Merged
merged 2 commits into from
Feb 20, 2021
Merged

Checksum errors may not be counted #11609

merged 2 commits into from
Feb 20, 2021

Conversation

don-brady
Copy link
Contributor

Motivation and Context

Fix regression seen in issue #11545 where checksum errors where not being counted or showing up in a zpool event.

Description

  1. Added a zfs_ereport_clear() function that will clear recent events after a pool scrub or vdev clear.
  2. Removed condition for increments of vd->vdev_stat.vs_checksum_errors (i.e. always increment).

How Has This Been Tested?

  1. Added new ZTS test, zpool_events_clear_retained, that verifies that after a scrub or vdev clear that new errors to the same block generate an event and are counted.
  2. ZFS Test suite ran against zpool_events and events tags
  3. Stock ztest run

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Feb 17, 2021
module/zfs/vdev.c Outdated Show resolved Hide resolved
module/zfs/spa.c Outdated Show resolved Hide resolved
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 18, 2021
@behlendorf behlendorf merged commit 03e02e5 into openzfs:master Feb 20, 2021
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Fix regression seen in issue openzfs#11545 where checksum errors 
where not being counted or showing up in a zpool event.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Don Brady <[email protected]>
Closes openzfs#11609
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Fix regression seen in issue openzfs#11545 where checksum errors 
where not being counted or showing up in a zpool event.

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Don Brady <[email protected]>
Closes openzfs#11609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants