vdev_id: Add error message when $CONFIG is missing #11498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was observed that vdev_id exists silently when the $CONFIG file is missing. This patch adds error message in case vdev_id is called without default $CONFIG or '-c'. This makes end user observe the exit message more easily. Before Patch: ~~~~~~~~~~~~~ $ ./cmd/vdev_id/vdev_id $ After Patch: ~~~~~~~~~~~~ $ ./cmd/vdev_id/vdev_id Error: Config file "/etc/zfs/vdev_id.conf" not found $ Signed-off-by: Arshad Hussain <[email protected]>
behlendorf
pushed a commit
that referenced
this pull request
Jan 25, 2021
It was observed that vdev_id exists silently when the $CONFIG file is missing. This patch adds error message in case vdev_id is called without default $CONFIG or '-c'. This makes end user observe the exit message more easily. Before Patch: ~~~~~~~~~~~~~ $ ./cmd/vdev_id/vdev_id $ After Patch: ~~~~~~~~~~~~ $ ./cmd/vdev_id/vdev_id Error: Config file "/etc/zfs/vdev_id.conf" not found $ Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Arshad Hussain <[email protected]> Closes #11498
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
It was observed that vdev_id exists silently when the $CONFIG file is missing. This patch adds error message in case vdev_id is called without default $CONFIG or '-c'. This makes end user observe the exit message more easily. Before Patch: ~~~~~~~~~~~~~ $ ./cmd/vdev_id/vdev_id $ After Patch: ~~~~~~~~~~~~ $ ./cmd/vdev_id/vdev_id Error: Config file "/etc/zfs/vdev_id.conf" not found $ Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Arshad Hussain <[email protected]> Closes openzfs#11498
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
It was observed that vdev_id exists silently when the $CONFIG file is missing. This patch adds error message in case vdev_id is called without default $CONFIG or '-c'. This makes end user observe the exit message more easily. Before Patch: ~~~~~~~~~~~~~ $ ./cmd/vdev_id/vdev_id $ After Patch: ~~~~~~~~~~~~ $ ./cmd/vdev_id/vdev_id Error: Config file "/etc/zfs/vdev_id.conf" not found $ Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Arshad Hussain <[email protected]> Closes openzfs#11498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that vdev_id exists silently when
the $CONFIG file is missing.
This patch adds error message in case vdev_id is
called without default $CONFIG or '-c'. This makes
end user observe the exit message more easily.
Signed-off-by: Arshad Hussain [email protected]
Motivation and Context
Minor improvement to vdev_id
Description
Adds Error message to vdev_id as an improvement to existing script/code.
How Has This Been Tested?
This was tested by running vdev_id script and forcing removal of $CONFIG file.
Types of changes
Checklist:
Signed-off-by.