Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct return type for getopt #11359

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

sterlingjensen
Copy link
Contributor

Otherwise clang complains about tautological-constant-out-of-range-compare

Signed-off-by: Sterling Jensen [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Otherwise clang complains about tautological-constant-out-of-range-compare

Signed-off-by: Sterling Jensen <[email protected]>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 17, 2020
@behlendorf behlendorf merged commit fb18840 into openzfs:master Dec 17, 2020
@sterlingjensen sterlingjensen deleted the fbsd_bldfix branch December 17, 2020 22:21
ghost pushed a commit to zfsonfreebsd/ZoF that referenced this pull request Dec 23, 2020
Use the correct return type for getopt otherwise clang complains
about tautological-constant-out-of-range-compare.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Sterling Jensen <[email protected]>
Closes openzfs#11359
behlendorf pushed a commit that referenced this pull request Dec 23, 2020
Use the correct return type for getopt otherwise clang complains
about tautological-constant-out-of-range-compare.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Sterling Jensen <[email protected]>
Closes #11359
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Use the correct return type for getopt otherwise clang complains
about tautological-constant-out-of-range-compare.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Sterling Jensen <[email protected]>
Closes openzfs#11359
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Use the correct return type for getopt otherwise clang complains
about tautological-constant-out-of-range-compare.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Sterling Jensen <[email protected]>
Closes openzfs#11359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants