Add -u option to 'zfs create' #11254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanjude
approved these changes
Nov 30, 2020
behlendorf
requested changes
Nov 30, 2020
cmd/zfs/zfs_main.c
Outdated
| @@ -1105,6 +1111,11 @@ zfs_do_create(int argc, char **argv) | |||
| "used when creating a volume\n")); | |||
| goto badusage; | |||
| } | |||
| if (nomount && type != ZFS_TYPE_FILESYSTEM) { | |||
| (void) fprintf(stderr, gettext("'-u' can only be " | |||
| "used when creating a file system\n")); | |||
There was a problem hiding this comment.
nit: It looks like all but a few of the error message use "filesystem" instead of "file system".
cmd/zfs/zfs_main.c
Outdated
| @@ -1265,7 +1276,8 @@ zfs_do_create(int argc, char **argv) | |||
| log_history = B_FALSE; | |||
| } | |||
|
|
|||
| ret = zfs_mount_and_share(g_zfs, argv[0], ZFS_TYPE_DATASET); | |||
| if (!nomount) | |||
| ret = zfs_mount_and_share(g_zfs, argv[0], ZFS_TYPE_DATASET); | |||
There was a problem hiding this comment.
Skipping the zfs_mount_and_share here looks like it will incorrectly leave the return value ret as 1.
ghost
force-pushed
the
create-o
branch
2 times, most recently
from
df56ff5 to
ea92198
Compare
|
behlendorf
approved these changes
Dec 1, 2020
behlendorf
added
Status: Accepted
|
It seems there's some trouble with the new test: |
Add -u option to 'zfs create' that prevents file system from being automatically mounted. This is similar to the 'zfs receive -u'. Authored by: pjd <[email protected]> FreeBSD-commit: freebsd/freebsd-src@35c5823 Ported-by: Ryan Moeller <[email protected]> Signed-off-by: Ryan Moeller <[email protected]>
ghost
added
Status: Code Review Needed
behlendorf
added
Status: Accepted
ghost
pushed a commit
to zfsonfreebsd/ZoF
that referenced
this pull request
Dec 23, 2020
Add -u option to 'zfs create' that prevents file system from being automatically mounted. This is similar to the 'zfs receive -u'. Authored by: pjd <[email protected]> FreeBSD-commit: freebsd/freebsd-src@35c5823 Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Allan Jude <[email protected]> Ported-by: Ryan Moeller <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes openzfs#11254
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Add -u option to 'zfs create' that prevents file system from being automatically mounted. This is similar to the 'zfs receive -u'. Authored by: pjd <[email protected]> FreeBSD-commit: freebsd/freebsd-src@35c5823 Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Allan Jude <[email protected]> Ported-by: Ryan Moeller <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes openzfs#11254
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Add -u option to 'zfs create' that prevents file system from being automatically mounted. This is similar to the 'zfs receive -u'. Authored by: pjd <[email protected]> FreeBSD-commit: freebsd/freebsd-src@35c5823 Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Allan Jude <[email protected]> Ported-by: Ryan Moeller <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes openzfs#11254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This was reported as a feature lost in FreeBSD with the switch to OpenZFS.
Description
Add -u option to 'zfs create' that prevents file system from being
automatically mounted. This is similar to the 'zfs receive -u'.
How Has This Been Tested?
This has been in FreeBSD since 2012. ZTS results pending.
Types of changes
Checklist:
Signed-off-by.