libzfsbootenv: do not depend on libnvpair #11227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not build libnvpair.pc. Moreover, it is automatically pulled in by libzfs.pc, so no additional specific depenency is required. Signed-off-by: Antonio Russo <[email protected]>
aerusso
force-pushed
the
pulls/libzfsbootenv-pc
branch
from
ef9db2c to
d1b9a7e
Compare
behlendorf
added
Status: Code Review Needed
|
@tsoome would you mind taking a look at this. Are there any concerns about dropping this direct dependency? |
behlendorf
approved these changes
Nov 22, 2020
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Nov 24, 2020
We do not build libnvpair.pc. Moreover, it is automatically pulled in by libzfs.pc, so no additional specific dependency is required. Reviewed by: Toomas Soome <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Antonio Russo <[email protected]> Closes #11227
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
We do not build libnvpair.pc. Moreover, it is automatically pulled in by libzfs.pc, so no additional specific dependency is required. Reviewed by: Toomas Soome <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Antonio Russo <[email protected]> Closes openzfs#11227
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
We do not build libnvpair.pc. Moreover, it is automatically pulled in by libzfs.pc, so no additional specific dependency is required. Reviewed by: Toomas Soome <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Antonio Russo <[email protected]> Closes openzfs#11227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We do not build libnvpair.pc. Moreover, it is automatically pulled in by libzfs.pc, so no additional specific depenency is required.
Description
This simply removes
libnvpairfrom the Requires block oflib/libzfsbootenv/libzfsbootenv.pc.in.How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.