Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the ABI with dist tarball #11225

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Include the ABI with dist tarball #11225

merged 1 commit into from
Nov 21, 2020

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

The make checkabi target should work given solely the release tarball.

Description

The ABI should be included when generating the make dist tarball
since it's required by the make checkabi target.

How Has This Been Tested?

tar -xzf <tarball.tar.gz>
./configure
make
make checkabi

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
Include the ABI with dist tarball
1feb621 
The ABI should be included when generating the `make dist` tarball
since it's required by the `make checkabi` target.

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf added Type: Building Indicates an issue related to building binaries Status: Code Review Needed Ready for review and testing Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 20, 2020
@behlendorf behlendorf merged commit f1ece31 into openzfs:master Nov 21, 2020
behlendorf added a commit that referenced this pull request Nov 22, 2020
@behlendorf
Include the ABI with dist tarball
056287e 
The ABI should be included when generating the `make dist` tarball
since it's required by the `make checkabi` target.

Signed-off-by: Brian Behlendorf <[email protected]>
Closes #11225
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@behlendorf @jsai20
Include the ABI with dist tarball
617eb92 
The ABI should be included when generating the `make dist` tarball
since it's required by the `make checkabi` target.

Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11225
@behlendorf behlendorf deleted the abidist branch April 19, 2021 19:21
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@behlendorf
Include the ABI with dist tarball
9f88f4c 
The ABI should be included when generating the `make dist` tarball
since it's required by the `make checkabi` target.

Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#11225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@behlendorf