-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zpool_influxdb: move to libexec dir #11224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wonder where the problem is, locally the test is passing:
|
richardelling
approved these changes
Nov 25, 2020
Move zpool_influxdb to libexec dir, as per following discussions: openzfs#11156 openzfs#11160 Signed-off-by: Pavel Snajdr <[email protected]>
- Move the zpool_influxdb command to /usr/libexec/zfs. Packages and generally expected to use a subdirectory. - Include the /usr/libexec/zfs path in the system search directory when running the test suite. Signed-off-by: Brian Behlendorf <[email protected]> Signed-off-by: Pavel Snajdr <[email protected]>
ff4e6f3
to
2895099
Compare
@behlendorf thanks a million, I'm sorry for the delays :( |
behlendorf
approved these changes
Nov 28, 2020
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Move the zpool_influxdb command to /usr/libexec/zfs, and include the /usr/libexec/zfs path in the system search directory when running the test suite. Reviewed-by: Richard Elling <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Pavel Snajdr <[email protected]> Closes openzfs#11156 Closes openzfs#11160 Closes openzfs#11224
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Move the zpool_influxdb command to /usr/libexec/zfs, and include the /usr/libexec/zfs path in the system search directory when running the test suite. Reviewed-by: Richard Elling <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Pavel Snajdr <[email protected]> Closes openzfs#11156 Closes openzfs#11160 Closes openzfs#11224
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jun 11, 2021
Move the zpool_influxdb command to /usr/libexec/zfs, and include the /usr/libexec/zfs path in the system search directory when running the test suite. Reviewed-by: Richard Elling <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Pavel Snajdr <[email protected]> Closes openzfs#11156 Closes openzfs#11160 Closes openzfs#11224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Move zpool_influxdb to libexec dir, as per following discussions:
#11156
#11160
Signed-off-by: Pavel Snajdr [email protected]
Description
I've used
libexec_PROGRAMS
autotools magic to install directly tolibexec
folder, I hope that is OK. It seemed more in-line with what we want to do here, I didn't want to create potentially unnecessary subfolder. Also added benefit is fewer lines for the install phase.How Has This Been Tested?
Builds & works locally, waiting for bots to confirm the tests work OK with new
LIBEXEC_DIR
variable.Types of changes
Checklist:
Signed-off-by
.