-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zpool: correctly align columns with -p, also manpage typo #11202
Closed
+41
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabijaczleweli
changed the title
zpool: correctly align columns with -p' also manpage typo
zpool: correctly align columns with -p, also manpage typo
Nov 13, 2020
nabijaczleweli
force-pushed
the
whats-an-alignment
branch
2 times, most recently
from
November 13, 2020 23:46
98195ab
to
90163fb
Compare
Dunno why tests are failing on some platforms; AFAICT from the few I've checked, these don't go anywhere close my code and they pass on other buildds. |
behlendorf
reviewed
Nov 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The CI failures were unrelated.
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
nabijaczleweli
force-pushed
the
whats-an-alignment
branch
from
November 14, 2020 19:04
90163fb
to
12a3a97
Compare
Signed-off-by: Ahelenia Ziemiańska <[email protected]>
nabijaczleweli
force-pushed
the
whats-an-alignment
branch
from
November 14, 2020 19:11
12a3a97
to
79a01ad
Compare
behlendorf
approved these changes
Nov 15, 2020
behlendorf
added
Status: Accepted
Ready to integrate (reviewed, tested)
and removed
Status: Code Review Needed
Ready for review and testing
labels
Nov 16, 2020
behlendorf
pushed a commit
that referenced
this pull request
Nov 16, 2020
zpool_expand_proplist() now ignores pl_fixed if its new literal argument is true. The rest is a consequence of needing to pass that down. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiao?=~Dska <[email protected]> Closes #11202
behlendorf
pushed a commit
that referenced
this pull request
Nov 17, 2020
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes #11202
behlendorf
pushed a commit
that referenced
this pull request
Nov 17, 2020
zpool_expand_proplist() now ignores pl_fixed if its new literal argument is true. The rest is a consequence of needing to pass that down. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiao?=~Dska <[email protected]> Closes #11202
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#11202
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
zpool_expand_proplist() now ignores pl_fixed if its new literal argument is true. The rest is a consequence of needing to pass that down. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiao?=~Dska <[email protected]> Closes openzfs#11202
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiańska <[email protected]> Closes openzfs#11202
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
zpool_expand_proplist() now ignores pl_fixed if its new literal argument is true. The rest is a consequence of needing to pass that down. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ahelenia Ziemiao?=~Dska <[email protected]> Closes openzfs#11202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This sucks:
This doesn't:
Description
zpool_expand_proplist()
now ignorespl_fixed
if its newliteral
argument is true.The rest is collateral damage to pass that down. This also, sadly, affects libzfs, but it's not like there's any guarantees on that.
Also there's a typo in the manpage.
How Has This Been Tested?
I ran
zpool list
,zpool get
, andzpool iostat
with-p
and they were usable.Types of changes
Checklist:
Signed-off-by
.