Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arcstat: Add -a and -p options from FreeNAS #11090

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2020

Added -a option to automatically print all valid statistics.
Added -p option to suppress scaling of printed data.

Authored by: Nick Principe [email protected]
Ported-by: Ryan Moeller [email protected]
Signed-off-by: Ryan Moeller [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

Added -a option to automatically print all valid statistics.
Added -p option to suppress scaling of printed data.

Authored by: Nick Principe <[email protected]>
Ported-by: Ryan Moeller <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
@ghost ghost added Status: Code Review Needed Ready for review and testing Component: Userspace user space functionality labels Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #11090 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11090      +/-   ##
==========================================
+ Coverage   79.72%   79.77%   +0.04%     
==========================================
  Files         397      397              
  Lines      125759   125759              
==========================================
+ Hits       100266   100321      +55     
+ Misses      25493    25438      -55     
Flag Coverage Δ
#kernel 80.42% <ø> (+0.01%) ⬆️
#user 65.82% <ø> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/zvol_id/zvol_id_main.c 76.31% <0.00%> (-5.27%) ⬇️
module/zfs/vdev_raidz.c 89.03% <0.00%> (-2.39%) ⬇️
cmd/zdb/zdb.c 80.50% <0.00%> (-1.15%) ⬇️
module/zfs/spa_log_spacemap.c 93.40% <0.00%> (-1.15%) ⬇️
module/os/linux/zfs/zfs_file_os.c 84.15% <0.00%> (-1.00%) ⬇️
module/zfs/vdev_initialize.c 97.15% <0.00%> (-0.95%) ⬇️
module/zfs/vdev_indirect.c 73.75% <0.00%> (-0.84%) ⬇️
module/zfs/vdev_trim.c 95.35% <0.00%> (-0.75%) ⬇️
lib/libzutil/os/linux/zutil_import_os.c 80.06% <0.00%> (-0.67%) ⬇️
module/icp/api/kcf_mac.c 38.85% <0.00%> (-0.58%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666aa69...b3fa402. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 21, 2020
@behlendorf behlendorf merged commit 2aaab88 into openzfs:master Oct 21, 2020
ghost pushed a commit to zfsonfreebsd/ZoF that referenced this pull request Oct 30, 2020
Added -a option to automatically print all valid statistics.
Added -p option to suppress scaling of printed data.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Authored by: Nick Principe <[email protected]>
Ported-by: Ryan Moeller <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11090
behlendorf pushed a commit that referenced this pull request Oct 30, 2020
Added -a option to automatically print all valid statistics.
Added -p option to suppress scaling of printed data.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Authored by: Nick Principe <[email protected]>
Ported-by: Ryan Moeller <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes #11090
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Added -a option to automatically print all valid statistics.
Added -p option to suppress scaling of printed data.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Authored by: Nick Principe <[email protected]>
Ported-by: Ryan Moeller <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11090
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Added -a option to automatically print all valid statistics.
Added -p option to suppress scaling of printed data.

Reviewed-by: George Melikov <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Authored by: Nick Principe <[email protected]>
Ported-by: Ryan Moeller <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Userspace user space functionality Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants