Share zfs_fsync, zfs_read, zfs_write, et al between Linux and FreeBSD #11078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mattmacy
force-pushed
the
projects/zfs_vnops
branch
from
5423b8b to
0bd5ef1
Compare
ghost
reviewed
Oct 16, 2020
ghost
requested a review
from 
Codecov Report
@@ Coverage Diff @@
## master #11078 +/- ##
==========================================
+ Coverage 79.70% 79.71% +0.01%
==========================================
Files 397 398 +1
Lines 125756 125745 -11
==========================================
+ Hits 100228 100242 +14
+ Misses 25528 25503 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Matt Macy <[email protected]>
mattmacy
force-pushed
the
projects/zfs_vnops
branch
from
0bd5ef1 to
1ede648
Compare
behlendorf
reviewed
Oct 19, 2020
mattmacy
force-pushed
the
projects/zfs_vnops
branch
from
1ede648 to
6566757
Compare
behlendorf
approved these changes
Oct 21, 2020
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Dec 23, 2020
The zfs_fsync, zfs_read, and zfs_write function are almost identical between Linux and FreeBSD. With a little refactoring they can be moved to the common code which is what is done by this commit. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Matt Macy <[email protected]> Closes #11078
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The zfs_fsync, zfs_read, and zfs_write function are almost identical between Linux and FreeBSD. With a little refactoring they can be moved to the common code which is what is done by this commit. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Matt Macy <[email protected]> Closes openzfs#11078
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
The zfs_fsync, zfs_read, and zfs_write function are almost identical between Linux and FreeBSD. With a little refactoring they can be moved to the common code which is what is done by this commit. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ryan Moeller <[email protected]> Signed-off-by: Matt Macy <[email protected]> Closes openzfs#11078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matt Macy [email protected]
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.