Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commitcheck on FreeBSD #11070

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 15, 2020

Convert from bash to sh, avoid Perl regexes and \s, prune unused
functions.

Signed-off-by: Ryan Moeller [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost ghost added the Status: Code Review Needed Ready for review and testing label Oct 15, 2020
@ghost ghost requested a review from behlendorf October 15, 2020 22:15
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #11070 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11070      +/-   ##
==========================================
+ Coverage   79.67%   79.76%   +0.09%     
==========================================
  Files         397      397              
  Lines      125756   125756              
==========================================
+ Hits       100191   100308     +117     
+ Misses      25565    25448     -117     
Flag Coverage Δ
#kernel 80.42% <ø> (-0.03%) ⬇️
#user 65.94% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
module/zfs/dsl_synctask.c 92.30% <0.00%> (-2.57%) ⬇️
module/zfs/zio_compress.c 92.72% <0.00%> (-1.82%) ⬇️
lib/libzfs/libzfs_changelist.c 85.18% <0.00%> (-1.12%) ⬇️
module/zfs/vdev_removal.c 96.49% <0.00%> (-0.80%) ⬇️
module/zfs/zio_checksum.c 98.31% <0.00%> (-0.57%) ⬇️
module/zfs/space_map.c 93.17% <0.00%> (-0.49%) ⬇️
module/zfs/vdev_indirect_mapping.c 98.55% <0.00%> (-0.49%) ⬇️
module/os/linux/zfs/zpl_xattr.c 83.89% <0.00%> (-0.43%) ⬇️
module/zfs/dmu_traverse.c 96.34% <0.00%> (-0.34%) ⬇️
module/lua/lauxlib.c 60.30% <0.00%> (-0.31%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e2b3d...97c0f04. Read the comment docs.

scripts/commitcheck.sh Outdated Show resolved Hide resolved
Convert from bash to sh, avoid Perl regexes and \s, prune unused
functions.

Signed-off-by: Ryan Moeller <[email protected]>
@ghost ghost force-pushed the commitcheck branch from 99b7b1e to 97c0f04 Compare October 16, 2020 19:00
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 20, 2020
@behlendorf behlendorf merged commit 777b8cc into openzfs:master Oct 20, 2020
@ghost ghost deleted the commitcheck branch October 20, 2020 18:51
behlendorf pushed a commit that referenced this pull request Oct 30, 2020
Convert from bash to sh, avoid Perl regexes and \s, prune unused
functions.

Reviewed-by: Mateusz Piotrowski <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes #11070
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Convert from bash to sh, avoid Perl regexes and \s, prune unused
functions.

Reviewed-by: Mateusz Piotrowski <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11070
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Convert from bash to sh, avoid Perl regexes and \s, prune unused
functions.

Reviewed-by: Mateusz Piotrowski <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants