-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix commitcheck on FreeBSD #11070
Merged
Merged
Fix commitcheck on FreeBSD #11070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from behlendorf
October 15, 2020 22:15
behlendorf
approved these changes
Oct 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #11070 +/- ##
==========================================
+ Coverage 79.67% 79.76% +0.09%
==========================================
Files 397 397
Lines 125756 125756
==========================================
+ Hits 100191 100308 +117
+ Misses 25565 25448 -117
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
0mp
reviewed
Oct 16, 2020
Convert from bash to sh, avoid Perl regexes and \s, prune unused functions. Signed-off-by: Ryan Moeller <[email protected]>
behlendorf
added
Status: Accepted
Ready to integrate (reviewed, tested)
and removed
Status: Code Review Needed
Ready for review and testing
labels
Oct 20, 2020
ghost
deleted the
commitcheck
branch
October 20, 2020 18:51
behlendorf
pushed a commit
that referenced
this pull request
Oct 30, 2020
Convert from bash to sh, avoid Perl regexes and \s, prune unused functions. Reviewed-by: Mateusz Piotrowski <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes #11070
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
Convert from bash to sh, avoid Perl regexes and \s, prune unused functions. Reviewed-by: Mateusz Piotrowski <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes openzfs#11070
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Convert from bash to sh, avoid Perl regexes and \s, prune unused functions. Reviewed-by: Mateusz Piotrowski <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Ryan Moeller <[email protected]> Closes openzfs#11070
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert from bash to sh, avoid Perl regexes and \s, prune unused
functions.
Signed-off-by: Ryan Moeller [email protected]
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.