Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Fix path to /dev/null in nopwrite_recsize #11026

Merged
merged 1 commit into from
Oct 8, 2020
Merged

ZTS: Fix path to /dev/null in nopwrite_recsize #11026

merged 1 commit into from
Oct 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 7, 2020

Motivation and Context

If you've ever noticed an odd /var/tmp/null file leftover after running ZTS, this is why.

Description

Don't direct stdout and stderr of dd to $TEST_BASE_DIR/null, direct it to /dev/null.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost ghost added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Oct 7, 2020
PrivatePuffin
PrivatePuffin approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@PrivatePuffin PrivatePuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, good fix.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 8, 2020
@behlendorf behlendorf merged commit 84cfe5d into openzfs:master Oct 8, 2020
@ghost ghost deleted the zts-null branch October 9, 2020 04:45
behlendorf pushed a commit that referenced this pull request Oct 16, 2020
@behlendorf
ZTS: Fix path to /dev/null in nopwrite_recsize
cbcb88d 
Don't direct stdout and stderr of dd to $TEST_BASE_DIR/null,
direct it to /dev/null.

Reviewed-by: Kjeld Schouten <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes #11026
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@jsai20
ZTS: Fix path to /dev/null in nopwrite_recsize
4878ef4 
Don't direct stdout and stderr of dd to $TEST_BASE_DIR/null,
direct it to /dev/null.

Reviewed-by: Kjeld Schouten <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11026
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
ZTS: Fix path to /dev/null in nopwrite_recsize
9154808 
Don't direct stdout and stderr of dd to $TEST_BASE_DIR/null,
direct it to /dev/null.

Reviewed-by: Kjeld Schouten <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: George Melikov <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#11026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behlendorf @gmelikov @PrivatePuffin