Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ubsan: shift exponent is too large #11024

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Fix ubsan: shift exponent is too large #11024

merged 1 commit into from
Oct 8, 2020

Conversation

ctuffli
Copy link
Contributor

@ctuffli ctuffli commented Oct 7, 2020

When running libzpool with the Undefined Behavior Sanitizer (ubsan)
enabled, a zpool create causes a run-time error:
module/zfs/vdev_label.c:600:14: runtime error: shift exponent 64 is
too large for 64-bit type 'long long unsigned int'`
in vdev_config_generate()

Fix is to convert vdev_removal_max_span to its base-2 logarithm, using
highbit64(), and then compare the "shifts".

Fixes #9744

Signed-off-by: Chuck Tuffli [email protected]

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

ahrens
ahrens approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@ahrens ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@ctuffli ctuffli force-pushed the vdev_config_generate branch from 4bcb47c to ce10ca8 Compare October 7, 2020 21:18
@ctuffli
Fix ubsan: shift exponent is too large
75a6156 
When running libzpool with the Undefined Behavior Sanitizer (ubsan)
enabled, a zpool create causes a run-time error:
    module/zfs/vdev_label.c:600:14: runtime error: shift exponent 64 is
    too large for 64-bit type 'long long unsigned int'`
in vdev_config_generate()

Fix is to convert vdev_removal_max_span to its base-2 logarithm, using
highbit64(), and then compare the "shifts".

Fixes openzfs#9744

Signed-off-by: Chuck Tuffli <[email protected]>
@ctuffli ctuffli force-pushed the vdev_config_generate branch from ce10ca8 to 75a6156 Compare October 7, 2020 21:45
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 8, 2020
@behlendorf behlendorf merged commit a8fc1b8 into openzfs:master Oct 8, 2020
@ctuffli ctuffli deleted the vdev_config_generate branch October 9, 2020 00:20
behlendorf pushed a commit that referenced this pull request Oct 16, 2020
@ctuffli @behlendorf
Fix ubsan: shift exponent is too large
0df5b57 
When running libzpool with the Undefined Behavior Sanitizer (ubsan)
enabled, a zpool create causes a run-time error:

    module/zfs/vdev_label.c:600:14: runtime error: shift exponent 64 is
    too large for 64-bit type 'long long unsigned int'`

in vdev_config_generate()

Fix is to convert vdev_removal_max_span to its base-2 logarithm, using
highbit64(), and then compare the "shifts".

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Chuck Tuffli <[email protected]>
Closes #9744
Closes #11024
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@ctuffli @jsai20
Fix ubsan: shift exponent is too large
7e1f588 
When running libzpool with the Undefined Behavior Sanitizer (ubsan)
enabled, a zpool create causes a run-time error:

    module/zfs/vdev_label.c:600:14: runtime error: shift exponent 64 is
    too large for 64-bit type 'long long unsigned int'`

in vdev_config_generate()

Fix is to convert vdev_removal_max_span to its base-2 logarithm, using
highbit64(), and then compare the "shifts".

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Chuck Tuffli <[email protected]>
Closes openzfs#9744
Closes openzfs#11024
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@ctuffli
Fix ubsan: shift exponent is too large
d94a2df 
When running libzpool with the Undefined Behavior Sanitizer (ubsan)
enabled, a zpool create causes a run-time error:

    module/zfs/vdev_label.c:600:14: runtime error: shift exponent 64 is
    too large for 64-bit type 'long long unsigned int'`

in vdev_config_generate()

Fix is to convert vdev_removal_max_span to its base-2 logarithm, using
highbit64(), and then compare the "shifts".

Reviewed-by: Matthew Ahrens <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Chuck Tuffli <[email protected]>
Closes openzfs#9744
Closes openzfs#11024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrens ahrens ahrens approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime error in vdev_config_generate
3 participants
@ctuffli @behlendorf @ahrens