-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Linux-Maximum to 5.8 #11019
Bump Linux-Maximum to 5.8 #11019
Conversation
Bump max kernel version to 5.8 to match the supported releases indicated in the release notes of 0.8.5 Signed-off-by: Nick Danyluk <[email protected]>
3d89d02
to
e053383
Compare
LGTM |
@Ornias1993 to be honest, I'm not sure. I only tested the 5.7/5.8 kernels on my system. Do the buildbots cover 2.6.32? This is my first OpenZFS PR, so I'd like to not break anything 😂 |
They don't, thats why I'm a bit hessitant to call 2.6.32 supported, personally.
Don't worry about it, your PR is perfectly fine :) |
@ndanyluk thanks for this fix - I overlooked updating it for the 0.8.5 release. Can you please make your PR against the @Ornias1993 we actually do support the 2.6.32 kernel for the 0.8.x release (since we support Centos 6), but we don't support it for |
I've been an idiot, Yes 2.6.32 is still automatically tested on 0.8.x |
No problem, happy to help! I just changed the base branch to 0.8.6 I think. |
Worked out pretty fine, don't worry about those test failures. Not your fault :) |
Perhaps this is a place where a rare 0.8.5.1 would be appropriate to get out quickly with this single fix? |
@gdevenyi the value in the META file is only informational. So while it may be a little misleading it won't cause any build issues. The 0.8.5 tag as is will build and work with the now released 5.9 kernel. I've gone ahead and updated the release notes to make it clear it's compatible. |
@behlendorf Is the value only informational? When I built DKMS packages on Ubuntu 20.04 I had to update META to include kernel 5.8 or my packages wouldn't build (at least if memory serves). |
Afaik some package creators do indeed use it. |
@ndanyluk that's right. If for some reason you needed to update META to get it to build I'd be interested to know why it failed. It's possible some of the downstream distribution packaging may make use of this. But if they're carrying patches for that, it seems reasonable they could manually bump the version in the META file for now as well. |
Bump max kernel version to 5.8 to match the supported releases indicated in the release notes of 0.8.5 Signed-off-by: Nick Danyluk <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Tony Hutter <[email protected]>
We squash all upstream commits from this release into one. This includes the following upstream commits: 2bc6689 "Tag zfs-0.8.6" 033c788 "Restore ARC MFU/MRU pressure" 26a3f3c "Linux 5.10 compat: check_disk_change() removed" 8c7d159 "Linux 5.10 compat: frame.h renamed objtool.h" 38cf54e "blkg_tryget config test: initialize struct" d7d0752 "copy-builtin: make sure kernel Makefiles don't look in zfs source tree" 3fdfb85 "copy-builtin: don't create sed backup files" acfc494 "copy-builtin: remove .gitignore from KERNEL_DIR/include/zfs" 0b4f698 "Increase Supported Linux Kernel to 5.9 (openzfs#11057)" e1be543 "Bump META Linux-Maximum to kernel 5.8 (openzfs#11019)"
Bump max kernel version to 5.8 to match the supported releases indicated in the release notes
Motivation and Context
Release 0.8.5 included fixes/commits targeting 5.8/5.9 compatibility. The release notes indicate support for kernels up to 5.8 but the META file still indicates 5.6.
This was first raised in one of the comments in the proposed 0.8.5 patch set
Description
I modified the META file to allow packages to be built for 5.7-5.8 kernels.
How Has This Been Tested?
I have only tested by building DKMS .deb packages on Ubuntu 20.04 (arm64, kernel 5.7 & 5.8 installed)
Types of changes
Checklist:
Signed-off-by
.