libzfsbootenv: lzbe_nvlist_set needs to store bootenv version VB_NVLIST #10937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small bug did slip into initial libzfsbootenv; while storing nvlist in nvlist, we should make sure the bootenv is using VB_NVLIST format. Signed-off-by: Toomas Soome <[email protected]>
behlendorf
approved these changes
Sep 17, 2020
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Sep 18, 2020
A small bug did slip into initial libzfsbootenv; while storing nvlist in nvlist, we should make sure the bootenv is using VB_NVLIST format. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Toomas Soome <[email protected]> Closes #10937
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
A small bug did slip into initial libzfsbootenv; while storing nvlist in nvlist, we should make sure the bootenv is using VB_NVLIST format. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Toomas Soome <[email protected]> Closes openzfs#10937
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
A small bug did slip into initial libzfsbootenv; while storing nvlist in nvlist, we should make sure the bootenv is using VB_NVLIST format. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Toomas Soome <[email protected]> Closes openzfs#10937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
A small bug did slip into initial libzfsbootenv; while storing nvlist
in nvlist, we should make sure the bootenv is using VB_NVLIST format.
Description
Check if version is set and has value VB_NVLIST. If not, create new nvlist with proper version set.
How Has This Been Tested?
Testing is done in FreeBSD, with zfsbootcfg utility (WIP: https://reviews.freebsd.org/D25512)
First set bootenv to have version 0
zfsbootenv -k version -t DATA_TYPE_UINT64 -v 0
zfsbootcfg -p # to see we do have version = 0 (VB_RAW)
zfsbootcfg -n freebsd:nvstore -k hello -v world
zfsbootcfg -p # to see we do have version changed to 1 (VB_NVLIST)
Types of changes
Checklist:
Signed-off-by.