Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD: drop dependency on cryptodev module #10901

Merged
merged 1 commit into from
Sep 9, 2020
Merged

FreeBSD: drop dependency on cryptodev module #10901

merged 1 commit into from
Sep 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 8, 2020

Motivation and Context

We only need the kernel interfaces in crypto, not the device node in
cryptodev.

Description

Drop the extra module dependency.

How Has This Been Tested?

Loaded openzfs module without cryptodev loaded. After load cryptodev remained unloaded and an encrypted dataset worked.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

FreeBSD: drop dependency on cryptodev module
31f5e49 
We only need the kernel interfaces in crypto, not the device node in
cryptodev.

Signed-off-by: Ryan Moeller <[email protected]>
@ghost ghost added the Status: Code Review Needed Ready for review and testing label Sep 8, 2020
@ghost ghost requested a review from amotin September 8, 2020 23:26
amotin
amotin approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. cryptodev(4) does not provide any kernel interfaces for ZFS to depend on.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 9, 2020
@behlendorf behlendorf merged commit cba6d86 into openzfs:master Sep 9, 2020
@ghost ghost deleted the no-cryptodev branch September 9, 2020 17:18
behlendorf pushed a commit that referenced this pull request Sep 9, 2020
@behlendorf
FreeBSD: drop dependency on cryptodev module
9cea5f0 
We only need the kernel interfaces in crypto, not the device node in
cryptodev.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes #10901
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@jsai20
FreeBSD: drop dependency on cryptodev module
62d7b4a 
We only need the kernel interfaces in crypto, not the device node in
cryptodev.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#10901
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
FreeBSD: drop dependency on cryptodev module
8f46722 
We only need the kernel interfaces in crypto, not the device node in
cryptodev.

Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan Moeller <[email protected]>
Closes openzfs#10901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @amotin