Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zvol: unsigned off can not be less than zero #10867

Merged
merged 1 commit into from
Sep 2, 2020
Merged

zvol: unsigned off can not be less than zero #10867

merged 1 commit into from
Sep 2, 2020

Conversation

tsoome
Copy link
Contributor

@tsoome tsoome commented Sep 2, 2020 •
edited
Loading

Warning from static analyzer (smatch). Originally detected in illumos, upstreaming the fix.

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@ghost ghost added the Status: Accepted Ready to integrate (reviewed, tested) label Sep 2, 2020
@behlendorf behlendorf merged commit 0db1b84 into openzfs:master Sep 2, 2020
@tsoome tsoome deleted the zvol branch September 3, 2020 08:57
behlendorf pushed a commit that referenced this pull request Sep 3, 2020
@tsoome @behlendorf
zvol: unsigned off can not be less than zero
ef8a6fe 
Reviewed-by: Richard Elling <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Toomas Soome <[email protected]>
Closes #10867
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@tsoome @jsai20
zvol: unsigned off can not be less than zero
f6b13d1 
Reviewed-by: Richard Elling <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Toomas Soome <[email protected]>
Closes openzfs#10867
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@tsoome
zvol: unsigned off can not be less than zero
26dea15 
Reviewed-by: Richard Elling <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Ryan Moeller <[email protected]>
Signed-off-by: Toomas Soome <[email protected]>
Closes openzfs#10867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardelling richardelling richardelling approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsoome @behlendorf @richardelling